Skip to content

Commit

Permalink
Update other references to BUCK2 version
Browse files Browse the repository at this point in the history
  • Loading branch information
kirklandsign committed May 21, 2024
1 parent 7ea4213 commit 49c8f19
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .ci/scripts/setup-macos.sh
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,12 @@ install_buck() {

pushd .ci/docker

# TODO(huydo): This is a one-off copy of buck2 2024-02-15 to unblock Jon and
# TODO(huydo): This is a one-off copy of buck2 2024-05-15 to unblock Jon and
# re-enable ShipIt. It’s not ideal that upgrading buck2 will require a manual
# update the cached binary on S3 bucket too. Let me figure out if there is a
# way to correctly implement the previous setup of installing a new version of
# buck2 only when it’s needed. AFAIK, the complicated part was that buck2
# --version doesn't say anything w.r.t its release version, i.e. 2024-02-15.
# --version doesn't say anything w.r.t its release version, i.e. 2024-05-15.
# See D53878006 for more details.
BUCK2=buck2-aarch64-apple-darwin.zst
curl -s "https://ossci-macos.s3.amazonaws.com/${BUCK2}" -o "${BUCK2}"
Expand Down
2 changes: 1 addition & 1 deletion build/test_ios.sh
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ set -e

OUTPUT="${1:-executorch}"
EXIT_STATUS=0
BUCK2_RELEASE_DATE="2024-02-15"
BUCK2_RELEASE_DATE="2024-05-15"
BUCK2_ARCHIVE="buck2-aarch64-apple-darwin.zst"
BUCK2=".venv/bin/buck2"
APP_PATH="examples/demo-apps/apple_ios/ExecuTorchDemo/ExecuTorchDemo"
Expand Down
2 changes: 1 addition & 1 deletion docs/source/getting-started-setup.md
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ To set up `Buck2`, You will need the following prerequisits for this section:
```
* Version `${executorch_version:buck2}` of the `buck2` commandline tool — you can download a
prebuilt archive for your system from [the Buck2
repo](https://github.com/facebook/buck2/releases/tag/2024-02-15). Note that
repo](https://github.com/facebook/buck2/releases/tag/2024-05-15). Note that
the version is important, and newer or older versions may not work with the
version of the buck2 prelude used by the ExecuTorch repo.
Expand Down

0 comments on commit 49c8f19

Please sign in to comment.