Skip to content

Commit

Permalink
Remove preprocess xplat build (#5801)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #5801

Fix the error
```
BUILD FAILED
Error running analysis for `fbsource//xplat/executorch/backends/qualcomm:preprocess (cfg:linux-x86_64-fbcode-platform010-clang15-no-san#5d1c5fc41fddc9ad)`

Caused by:
    0: Error in configured node dependency, dependency chain follows (-> indicates depends on, ^ indicates same configuration as previous):
              fbsource//xplat/executorch/backends/qualcomm:preprocess (cfg:linux-x86_64-fbcode-platform010-clang15-no-san#5d1c5fc41fddc9ad)
           -> fbsource//xplat/executorch/backends/qualcomm/passes:passes (^)

    1: looking up unconfigured target node `fbsource//xplat/executorch/backends/qualcomm/passes:passes`
    2: Error loading targets in package `fbsource//xplat/executorch/backends/qualcomm/passes` for target `fbsource//xplat/executorch/backends/qualcomm/passes:passes`
    3: package `fbsource//xplat/executorch/backends/qualcomm/passes:` does not exist
           missing `BUCK` file (also missing alternatives `BUCK.v2`, `BUCK`)
```
In https://www.internalfb.com/sandcastle/workflow/941252322124876986/artifact/actionlog.941252322206237690.stdout.1?selectedLines=622-633-1-77

Reviewed By: SS-JIA

Differential Revision: D63587929

fbshipit-source-id: 3fdf0065417b41f58966b08d01a1a19c2451fa9c
  • Loading branch information
cccclai authored and facebook-github-bot committed Oct 2, 2024
1 parent 43d7662 commit 393553c
Show file tree
Hide file tree
Showing 4 changed files with 29 additions and 39 deletions.
13 changes: 13 additions & 0 deletions backends/qualcomm/TARGETS
Original file line number Diff line number Diff line change
@@ -1,5 +1,18 @@
load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime")
load(":targets.bzl", "define_common_targets")

oncall("executorch")

define_common_targets()

runtime.python_library(
name = "preprocess",
srcs = ["qnn_preprocess.py"],
visibility = [
"//executorch/backends/qualcomm/...",
"@EXECUTORCH_CLIENTS",
],
deps = [
"//executorch/backends/qualcomm/passes:passes",
],
)
17 changes: 15 additions & 2 deletions backends/qualcomm/passes/TARGETS
Original file line number Diff line number Diff line change
@@ -1,5 +1,18 @@
load(":targets.bzl", "define_common_targets")
load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime")

oncall("executorch")

define_common_targets()
runtime.python_library(
name = "passes",
srcs = glob([
"*.py",
]),
visibility = [
"@EXECUTORCH_CLIENTS",
],
deps = [
"//executorch/backends/transforms:addmm_mm_to_linear",
"//executorch/exir/backend:backend_details",
"//executorch/exir/backend:compile_spec_schema",
],
)
22 changes: 0 additions & 22 deletions backends/qualcomm/passes/targets.bzl

This file was deleted.

16 changes: 1 addition & 15 deletions backends/qualcomm/targets.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,8 @@ load(
"@fbsource//tools/build_defs:default_platform_defs.bzl",
"ANDROID",
)
load("@fbcode_macros//build_defs:python_library.bzl", "python_library")
load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime")


# Construct the input and output file names. All input and output files rely on scalar_type file.
SCHEMA_NAME = "schema"

Expand Down Expand Up @@ -56,6 +54,7 @@ def define_common_targets():
[OUTPUT_SCHEMA_HEADER],
OUTPUT_SCHEMA_HEADER,
)

# Header-only library target with the generate executorch program schema header.
runtime.cxx_library(
name = "schema",
Expand All @@ -77,7 +76,6 @@ def define_common_targets():
platforms = [ANDROID],
)


runtime.cxx_library(
name = "qnn_executorch_backend",
srcs = [],
Expand All @@ -94,15 +92,3 @@ def define_common_targets():
":schema",
],
)

runtime.python_library(
name = "preprocess",
srcs = ["qnn_preprocess.py"],
deps = [
"//executorch/backends/qualcomm/passes:passes",
],
visibility = [
"//executorch/backends/qualcomm/...",
"@EXECUTORCH_CLIENTS",
],
)

0 comments on commit 393553c

Please sign in to comment.