Update TP examples to align with tutorials #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-examples-preview canceled.
|
tianyu-l
approved these changes
Apr 9, 2024
|
not sure why the import fails... pls fix |
wanchaol
force-pushed
the
tp_tutorial
branch
4 times, most recently
from
db7e1ce
to
9b3dd53
Compare
msaroufim
reviewed
Apr 10, 2024
| @@ -3,4 +3,4 @@ | |||
| --pre | |||
| --extra-index-url https://download.pytorch.org/whl/nightly/cu118 | |||
| --extra-index-url https://download.pytorch.org/whl/nightly/cu121 | |||
| torch >= 2.2.0.dev0; sys_platform == "linux" | |||
| torch >= 2.3.0.dev0; sys_platform == "linux" | |||
There was a problem hiding this comment.
btw would this example work on T4 GPUs? Most of the distributed work here is still untested but there's no real reason for that IMO
Setting up distributed CI is as simple as runs-on: 4-core-ubuntu-gpu-t4
There was a problem hiding this comment.
Cool let me try this!
msaroufim
reviewed
Apr 10, 2024
msaroufim
approved these changes
Apr 10, 2024
wanchaol
force-pushed
the
tp_tutorial
branch
7 times, most recently
from
9ca0137
to
14f4f6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as titled