Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PairwiseGP GPU compatibility #537

Closed
wants to merge 1 commit into from

Conversation

ItsMrLin
Copy link
Contributor

@ItsMrLin ItsMrLin commented Sep 9, 2020

Summary: Enabling PairwiseGP to work with GPU

Differential Revision: D23570258

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D23570258

ItsMrLin added a commit to ItsMrLin/botorch that referenced this pull request Sep 10, 2020
Summary:
Pull Request resolved: pytorch#537

Enabling PairwiseGP to work with GPU

Differential Revision: D23570258

fbshipit-source-id: 362fb3941b9cc9272dd13df10e7873a5315f813b
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D23570258

@codecov
Copy link

codecov bot commented Sep 10, 2020

Codecov Report

Merging #537 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #537   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           83        83           
  Lines         5330      5339    +9     
=========================================
+ Hits          5330      5339    +9     
Impacted Files Coverage Δ
botorch/models/pairwise_gp.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7258e56...e04f165. Read the comment docs.

ItsMrLin added a commit to ItsMrLin/botorch that referenced this pull request Sep 10, 2020
Summary:
Pull Request resolved: pytorch#537

Enabling PairwiseGP to work with GPU

Differential Revision: D23570258

fbshipit-source-id: eccff65b3b4cf8ee14ddfabef1fde5da47f1c1ff
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D23570258

ItsMrLin added a commit to ItsMrLin/botorch that referenced this pull request Sep 10, 2020
Summary:
Pull Request resolved: pytorch#537

Enabling PairwiseGP to work with GPU

Reviewed By: Balandat

Differential Revision: D23570258

fbshipit-source-id: 8d3c8b71be51604ee1b1f6e84db7d7ecd8a5d9db
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D23570258

Summary:
Pull Request resolved: pytorch#537

Enabling PairwiseGP to work with GPU

Reviewed By: Balandat

Differential Revision: D23570258

fbshipit-source-id: 101cee1582a65eed5f321fbd0e120c1ecc10ae95
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D23570258

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in de486e3.

facebook-github-bot pushed a commit that referenced this pull request Sep 11, 2020
Summary:
#### New Features
* Constrained Multi-Objective tutorial (#493)
* Multi-fidelity Knowledge Gradient tutorial (#509)
* Support for batch qMC sampling (#510)
* New `evaluate` method for `qKnowledgeGradient` (#515)

#### Compatibility
* Require PyTorch >=1.6 (#535)
* Require GPyTorch >=1.2 (#535)
* Remove deprecated `botorch.gen module` (#532)

#### Bug fixes
* Fix bad backward-indexing of task_feature in `MultiTaskGP` (#485)
* Fix bounds in constrained Branin-Currin test function (#491)
* Fix max_hv for C2DTLZ2 and make Hypervolume always return a float (#494)
* Fix bug in `draw_sobol_samples` that did not use the proper effective dimension (#505)
* Fix constraints for `q>1` in `qExpectedHypervolumeImprovement` (c80c4fd)
* Only use feasible observations in partitioning for `qExpectedHypervolumeImprovement`
  in `get_acquisition_function` (#523)
* Improved GPU compatibility for `PairwiseGP` (#537)

#### Performance Improvements
* Reduce memory footprint in `qExpectedHypervolumeImprovement` (#522)
* Add `(q)ExpectedHypervolumeImprovement` to nonnegative functions
  [for better initialization] (#496)

#### Other changes
* Support batched `best_f` in `qExpectedImprovement` (#487)
* Allow to return full tree of solutions in `OneShotAcquisitionFunction` (#488)
* Added `construct_inputs` class method to models to programmatically construct the
  inputs to the constructor from a standardized `TrainingData` representation
  (#477, #482, 3621198)
* Acqusiition function constructors now accept catch-all `**kwargs` options
  (#478, e5b6935)
* Use `psd_safe_cholesky` in `qMaxValueEntropy` for better numerical stabilty (#518)
* Added `WeightedMCMultiOutputObjective` (81d91fd)
* Add ability to specify `outcomes` to all multi-output objectives (#524)
* Return optimization output in `info_dict` for `fit_gpytorch_scipy` (#534)
* Use `setuptools_scm` for versioning (#539)

Pull Request resolved: #542

Reviewed By: sdaulton

Differential Revision: D23645619

Pulled By: Balandat

fbshipit-source-id: 0384f266cbd517aacd5778a6e2680336869bb31c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants