Supporting InputTransforms in SparseOutlierLikelihood and get_posterior_over_support
#2659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
SebastianAment
force-pushed
the
export-D67605578
branch
from
3ca453d to
858b587
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67605578 |
|
This pull request was exported from Phabricator. Differential Revision: D67605578 |
SebastianAment
added a commit
to SebastianAment/botorch
that referenced
this pull request
Dec 23, 2024
Summary: Pull Request resolved: pytorch#2659 Adding support to using the `SparseOutlierLikelihood` in conjunction with input transforms. In `eval` model, BoTorch applies input transforms in the posterior call. For this reason, the likelihood will receive un-transformed inputs during training, but transformed inputs during inference. So we need to make sure to store the transformed inputs in the training data cache of `SparseOutlierNoise` for inference comparisons. Differential Revision: D67605578
SebastianAment
force-pushed
the
export-D67605578
branch
from
858b587 to
5888caa
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2659 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 200 200
Lines 18155 18157 +2
=======================================
+ Hits 18153 18155 +2
Misses 2 2 ☔ View full report in Codecov by Sentry. |
SebastianAment
added a commit
to SebastianAment/botorch
that referenced
this pull request
Jan 3, 2025
…sterior_over_support` (pytorch#2659) Summary: Adding support to using the `SparseOutlierLikelihood` in conjunction with input transforms. To do this, we need to pass the transformed inputs separately to any of the marginal likelihood computation similar to the [model closures in the model fitting routines](https://github.com/pytorch/botorch/blob/466da73a18731d45b034bfd36011bb3eb150fdd8/botorch/optim/closures/model_closures.py#L185). Differential Revision: D67605578
SebastianAment
force-pushed
the
export-D67605578
branch
from
5888caa to
5e49c0c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67605578 |
SebastianAment
changed the title
input_transform in SparseOutlierLikelihoodInputTransforms in SparseOutlierLikelihood and get_posterior_over_support
SebastianAment
added a commit
to SebastianAment/botorch
that referenced
this pull request
Jan 3, 2025
…sterior_over_support` (pytorch#2659) Summary: Adding support to using the `SparseOutlierLikelihood` in conjunction with input transforms. To do this, we need to pass the transformed inputs separately to any of the marginal likelihood computation similar to the [model closures in the model fitting routines](https://github.com/pytorch/botorch/blob/466da73a18731d45b034bfd36011bb3eb150fdd8/botorch/optim/closures/model_closures.py#L185). Differential Revision: D67605578
SebastianAment
force-pushed
the
export-D67605578
branch
from
5e49c0c to
fb543f1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67605578 |
SebastianAment
added a commit
to SebastianAment/botorch
that referenced
this pull request
Jan 3, 2025
…sterior_over_support` (pytorch#2659) Summary: Adding support to using the `SparseOutlierLikelihood` in conjunction with input transforms. To do this, we need to pass the transformed inputs separately to any of the marginal likelihood computation similar to the [model closures in the model fitting routines](https://github.com/pytorch/botorch/blob/466da73a18731d45b034bfd36011bb3eb150fdd8/botorch/optim/closures/model_closures.py#L185). Differential Revision: D67605578
SebastianAment
force-pushed
the
export-D67605578
branch
from
fb543f1 to
890c6e0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67605578 |
SebastianAment
added a commit
to SebastianAment/botorch
that referenced
this pull request
Jan 3, 2025
…sterior_over_support` (pytorch#2659) Summary: Adding support to using the `SparseOutlierLikelihood` in conjunction with input transforms. To do this, we need to pass the transformed inputs separately to any of the marginal likelihood computation similar to the [model closures in the model fitting routines](https://github.com/pytorch/botorch/blob/466da73a18731d45b034bfd36011bb3eb150fdd8/botorch/optim/closures/model_closures.py#L185). Differential Revision: D67605578
SebastianAment
force-pushed
the
export-D67605578
branch
from
890c6e0 to
88efee0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67605578 |
…sterior_over_support` (pytorch#2659) Summary: Adding support to using the `SparseOutlierLikelihood` in conjunction with input transforms. To do this, we need to pass the transformed inputs separately to any of the marginal likelihood computation similar to the [model closures in the model fitting routines](https://github.com/pytorch/botorch/blob/466da73a18731d45b034bfd36011bb3eb150fdd8/botorch/optim/closures/model_closures.py#L185). Reviewed By: saitcakmak Differential Revision: D67605578
SebastianAment
force-pushed
the
export-D67605578
branch
from
88efee0 to
3bd6fdf
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67605578 |
|
This pull request has been merged in aef25d7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adding support to using the
SparseOutlierLikelihoodin conjunction with input transforms. To do this, we need to pass the transformed inputs separately to any of the marginal likelihood computation similar to the model closures in the model fitting routines.Differential Revision: D67605578