Deprecate gp_sampling module in favor of pathwise sampling #2432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D59815658 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2432 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 189 189
Lines 16675 16696 +21
=======================================
+ Hits 16673 16694 +21
Misses 2 2 ☔ View full report in Codecov by Sentry. |
|
This pull request was exported from Phabricator. Differential Revision: D59815658 |
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Jul 18, 2024
) Summary: Pull Request resolved: pytorch#2432 GP sampling functionality has been superseded by pathwise sampling, which has been in BoTorch for quite some time now. Marking it for deprecation in v0.13. All existing usage has been replaced with `get_matheron_path_model`. Differential Revision: D59815658
saitcakmak
force-pushed
the
export-D59815658
branch
from
0b0b639 to
00268d1
Compare
…pytorch#2435) Summary: Pull Request resolved: pytorch#2435 Out of the box, pathwise sampling code does not produce outputs that conform to BoTorch modeling conventions. This adds a helper that produces a Matheron path and wraps it in a `GenericDeterministicModel` using a helper that reshapes the path outputs to mimic the expected behavior from the model's posterior. This will offer a straightforward replacement of `get_gp_samples`, which is being deprecated. Differential Revision: D59941730
) Summary: Pull Request resolved: pytorch#2432 GP sampling functionality has been superseded by pathwise sampling, which has been in BoTorch for quite some time now. Marking it for deprecation in v0.13. All existing usage has been replaced with `get_matheron_path_model`. Differential Revision: D59815658
|
This pull request was exported from Phabricator. Differential Revision: D59815658 |
saitcakmak
force-pushed
the
export-D59815658
branch
from
00268d1 to
339daab
Compare
|
This pull request has been merged in 53d8f88. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: GP sampling functionality has been superseded by pathwise sampling, which has been in BoTorch for quite some time now. Marking it for deprecation in v0.13.
Differential Revision: D59815658