Deprecate model conversion code #2431
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D59813960 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2431 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 189 189
Lines 16685 16693 +8
=======================================
+ Hits 16683 16691 +8
Misses 2 2 ☔ View full report in Codecov by Sentry. |
Summary: Pull Request resolved: pytorch#2431 These utilities are scarcely used and poorly maintained. They also are not fully compatible with different GPyTorch priors that we plan to use by default in the near future. Marking them for deprecation in v0.13. Also added an explicit warning when used with priors that do not have any state dict, since such priors cannot be verified to be compatible across submodels. Reviewed By: SebastianAment Differential Revision: D59813960
|
This pull request was exported from Phabricator. Differential Revision: D59813960 |
saitcakmak
force-pushed
the
export-D59813960
branch
from
ff4afa1 to
cf4fcc7
Compare
|
This pull request has been merged in e7915b1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
These utilities are scarcely used and poorly maintained. They also are not fully compatible with different GPyTorch priors that we plan to use by default in the near future. Marking them for deprecation in v0.13.
Also added an explicit warning when used with priors that do not have any state dict, since such priors cannot be verified to be compatible across submodels.
Differential Revision: D59813960