Add dtype torch.double to basic example on website
#2395
Conversation
facebook-github-bot
added
the
CLA Signed
website/pages/en/index.js
Outdated
| @@ -19,8 +19,8 @@ const bash = (...args) => `~~~bash\n${String.raw(...args)}\n~~~`; | |||
|
|
|||
| class HomeSplash extends React.Component { | |||
| render() { | |||
| const {siteConfig, language = ''} = this.props; | |||
| const {baseUrl, docsUrl} = siteConfig; | |||
| const { siteConfig, language = '' } = this.props; | |||
There was a problem hiding this comment.
What happened here? An auto-formatter?
There was a problem hiding this comment.
I don't think the whitespace matters, but I'll revert this for extra safety.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2395 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 191 191
Lines 16715 16715
=======================================
Hits 16712 16712
Misses 3 3 ☔ View full report in Codecov by Sentry. |
|
Thanks so much for this. Some of the documentation is older and has fallen out of step with currently recommended best practices, so I really appreciate this -- failing to use double precision is a common "gotcha." |
|
@esantorella has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@esantorella has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Thanks! |
|
@esantorella merged this pull request in ef73ea6. |
Motivation
By chance, I encountered that there is no explicit dtype provided in the basic example on the botorch website, which then throws a warning when running the code, which I find kind of annoying. This PR just adds
dtype=torch.doubleto the example, as it is also done for somehow the same code example in theREADME.mdon github.Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
No additional tests needed.