Remove UnstandardizeMCMultiOutputObjective #2362
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D58164130 |
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Jun 4, 2024
Summary: There is no reason to use this instead of the `Standardize` outcome transform. We could add a deprecation warning and remove it at a later release, but it is hidden deep in the code base that I think it's ok to remove it outright. I couldn't find any usage anywhere. Reviewed By: Balandat Differential Revision: D58164130
saitcakmak
force-pushed
the
export-D58164130
branch
from
866c9d8 to
0430181
Compare
|
This pull request was exported from Phabricator. Differential Revision: D58164130 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2362 +/- ##
==========================================
- Coverage 99.98% 99.98% -0.01%
==========================================
Files 189 189
Lines 16548 16516 -32
==========================================
- Hits 16545 16513 -32
Misses 3 3 ☔ View full report in Codecov by Sentry. |
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Jun 5, 2024
…Transform (pytorch#2362) Summary: There is no reason to use these instead of the `Standardize` outcome transform. We could add a deprecation warning and remove it at a later release, but it is hidden deep in the code base that I think it's ok to remove it outright. I couldn't find any usage anywhere. Reviewed By: Balandat Differential Revision: D58164130
saitcakmak
force-pushed
the
export-D58164130
branch
from
0430181 to
71dcc7d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D58164130 |
…Transform (pytorch#2362) Summary: There is no reason to use these instead of the `Standardize` outcome transform. We could add a deprecation warning and remove it at a later release, but it is hidden deep in the code base that I think it's ok to remove it outright. I couldn't find any usage anywhere. Reviewed By: Balandat Differential Revision: D58164130
saitcakmak
force-pushed
the
export-D58164130
branch
from
71dcc7d to
cc9d770
Compare
|
This pull request was exported from Phabricator. Differential Revision: D58164130 |
|
This pull request has been merged in 91b45b7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: There is no reason to use this instead of the
Standardizeoutcome transform. We could add a deprecation warning and remove it at a later release, but it is hidden deep in the code base that I think it's ok to remove it outright. I couldn't find any usage anywhere.Reviewed By: Balandat
Differential Revision: D58164130