modify PenalizedMCObjective to support non-batch eval
#2073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49305807 |
Codecov Report
@@ Coverage Diff @@
## main #2073 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 179 179
Lines 15858 15861 +3
=========================================
+ Hits 15858 15861 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Summary: To match penalty term with MC objective, we current unsqueeze the first dim which corresponds to the dimension of MC samples. However, when a `qxd`-dim X tensor is evaluated e.g. computing feasibility, it causes shape mismatch. As one would expect `q`-dim tensor returned, it will return `1xq`-dim tensor instead. To fix, we check the dims of obj; if it is non-mc samples, we will sequeeze the first dim back. Differential Revision: D49305807
qingfeng10
force-pushed
the
export-D49305807
branch
from
307f98f to
992b5b2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49305807 |
|
This pull request has been merged in e1cb934. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
To match penalty term with MC objective, we current unsqueeze the first dim which corresponds to the dimension of MC samples. However, when a
qxd-dim X tensor is evaluated e.g. computing feasibility, it causes shape mismatch. As one would expectq-dim tensor returned, it will return1xq-dim tensor instead.To fix, we check the dims of obj; if it is non-mc samples, we will sequeeze the first dim back.
Differential Revision: D49305807