Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add constructor inputs for contextual GP #2057

Closed
wants to merge 1 commit into from
Closed

add constructor inputs for contextual GP #2057

wants to merge 1 commit into from

Conversation

qingfeng10
Copy link
Contributor

Summary: In order to enable SACGP/LCEMGP in MBM, we need to add input constructors for the two models.

Reviewed By: saitcakmak

Differential Revision: D50417893

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Oct 18, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50417893

qingfeng10 added a commit to qingfeng10/botorch that referenced this pull request Oct 18, 2023
@qingfeng10 @facebook-github-bot
add constructor inputs for contextual GP (pytorch#2057)
3517788 
Summary:

In order to enable SACGP/LCEMGP in MBM, we need to add input constructors for the two models.

Reviewed By: saitcakmak

Differential Revision: D50417893
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50417893

@codecov
Copy link

codecov bot commented Oct 18, 2023 •
edited
Loading

Codecov Report

Merging #2057 (110ee58) into main (41e1c37) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 110ee58 differs from pull request most recent head 4638900. Consider uploading reports for the commit 4638900 to get more accurate results

@@            Coverage Diff            @@
##              main     #2057   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          179       179           
  Lines        15838     15847    +9     
=========================================
+ Hits         15838     15847    +9
Files Coverage Δ
botorch/models/contextual.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

qingfeng10 added a commit to qingfeng10/botorch that referenced this pull request Oct 18, 2023
@qingfeng10 @facebook-github-bot
add constructor inputs for contextual GP (pytorch#2057)
af665af 
Summary:

In order to enable SACGP/LCEMGP in MBM, we need to add input constructors for the two models.

Reviewed By: saitcakmak

Differential Revision: D50417893
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50417893

@qingfeng10 @facebook-github-bot
add constructor inputs for contextual GP (pytorch#2057)
4638900 
Summary:

In order to enable SACGP/LCEMGP in MBM, we need to add input constructors for the two models.

Reviewed By: saitcakmak

Differential Revision: D50417893
qingfeng10 added a commit to qingfeng10/botorch that referenced this pull request Oct 18, 2023
@qingfeng10 @facebook-github-bot
add constructor inputs for contextual GP (pytorch#2057)
4042f47 
Summary:

In order to enable SACGP/LCEMGP in MBM, we need to add input constructors for the two models.

Reviewed By: saitcakmak

Differential Revision: D50417893
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50417893

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50417893

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in a424f6f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qingfeng10 @facebook-github-bot