Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Even more fixes to unused kwargs #1985

Closed
wants to merge 1 commit into from
Closed

Even more fixes to unused kwargs #1985

wants to merge 1 commit into from

Conversation

esantorella
Copy link
Member

Summary: See previous diff

Differential Revision: D48338443

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 15, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48338443

esantorella added a commit to esantorella/Ax that referenced this pull request Aug 15, 2023
@esantorella @facebook-github-bot
Even more fixes to unused kwargs
f2f81bf 
Summary:
X-link: pytorch/botorch#1985

See previous diff

Differential Revision: D48338443

fbshipit-source-id: 474b23d43b40421b3cc96bbea5cf95b329b46afc
@esantorella esantorella mentioned this pull request Aug 15, 2023
Closed
@codecov
Copy link

codecov bot commented Aug 15, 2023 •
edited
Loading

Codecov Report

Merging #1985 (3d4e8d7) into main (b6e74ac) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 3d4e8d7 differs from pull request most recent head 35a6556. Consider uploading reports for the commit 35a6556 to get more accurate results

@@            Coverage Diff            @@
##              main     #1985   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          178       178           
  Lines        15725     15720    -5     
=========================================
- Hits         15725     15720    -5
Files Changed Coverage Δ
botorch/acquisition/knowledge_gradient.py 100.00% <ø> (ø)
botorch/acquisition/max_value_entropy_search.py 100.00% <ø> (ø)
botorch/acquisition/input_constructors.py 100.00% <100.00%> (ø)
botorch/acquisition/joint_entropy_search.py 100.00% <100.00%> (ø)
botorch/acquisition/monte_carlo.py 100.00% <100.00%> (ø)
botorch/acquisition/multi_objective/monte_carlo.py 100.00% <100.00%> (ø)
botorch/acquisition/utils.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

sdaulton pushed a commit to sdaulton/Ax-1 that referenced this pull request Aug 15, 2023
@esantorella @facebook-github-bot
Even more fixes to unused kwargs (facebook#1782)
66ee0af 
Summary:
Pull Request resolved: facebook#1782

X-link: pytorch/botorch#1985

See previous diff

Differential Revision: D48338443

fbshipit-source-id: 9053999cb34b616c0eca8ae9994ee6534212391c
sdaulton pushed a commit to sdaulton/botorch that referenced this pull request Aug 15, 2023
@esantorella @facebook-github-bot
Even more fixes to unused kwargs (pytorch#1985)
5198f51 
Summary:
X-link: facebook/Ax#1782

Pull Request resolved: pytorch#1985

See previous diff

Differential Revision: D48338443

fbshipit-source-id: daff75e433cc1732e4e8c702eab87195ea9ea024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48338443

esantorella added a commit to esantorella/botorch that referenced this pull request Aug 16, 2023
@esantorella @facebook-github-bot
Even more fixes to unused kwargs (pytorch#1985)
0b04b96 
Summary:
X-link: facebook/Ax#1782

Pull Request resolved: pytorch#1985

See previous diff

Reviewed By: lena-kashtelyan

Differential Revision: D48338443

fbshipit-source-id: 7cacc33ead6d5471855364eff910031640bc4708
esantorella added a commit to esantorella/Ax that referenced this pull request Aug 16, 2023
@esantorella @facebook-github-bot
Even more fixes to unused kwargs (facebook#1782)
86cb356 
Summary:
Pull Request resolved: facebook#1782

X-link: pytorch/botorch#1985

See previous diff

Reviewed By: lena-kashtelyan

Differential Revision: D48338443

fbshipit-source-id: 5231d7bfe20eacffaf15e029657ede64e397c037
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48338443

esantorella added a commit to esantorella/botorch that referenced this pull request Aug 16, 2023
@esantorella @facebook-github-bot
Even more fixes to unused kwargs (pytorch#1985)
fcff3af 
Summary:
X-link: facebook/Ax#1782

Pull Request resolved: pytorch#1985

See previous diff

Reviewed By: lena-kashtelyan

Differential Revision: D48338443

fbshipit-source-id: 3bb4762ae6a2a6997aff986a7fad1b2dc7391a8e
esantorella added a commit to esantorella/Ax that referenced this pull request Aug 16, 2023
@esantorella @facebook-github-bot
Even more fixes to unused kwargs (facebook#1782)
10f0a33 
Summary:
Pull Request resolved: facebook#1782

X-link: pytorch/botorch#1985

See previous diff

Reviewed By: lena-kashtelyan

Differential Revision: D48338443

fbshipit-source-id: 314fc711a4a59ce72035028bbe89d4c449f966ca
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48338443

esantorella added a commit to esantorella/botorch that referenced this pull request Aug 17, 2023
@esantorella @facebook-github-bot
Even more fixes to unused kwargs (pytorch#1985)
2297246 
Summary:
X-link: facebook/Ax#1782

Pull Request resolved: pytorch#1985

See previous diff

Reviewed By: lena-kashtelyan

Differential Revision: D48338443

fbshipit-source-id: ff3ba0cae043e555d4957505ed35ad2bdb54411d
esantorella added a commit to esantorella/Ax that referenced this pull request Aug 17, 2023
@esantorella @facebook-github-bot
Even more fixes to unused kwargs (facebook#1782)
fe2af4c 
Summary:
Pull Request resolved: facebook#1782

X-link: pytorch/botorch#1985

See previous diff

Reviewed By: lena-kashtelyan

Differential Revision: D48338443

fbshipit-source-id: b0dddbd9ef1a4f95eb862d567afa28f430e1f3b4
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48338443

esantorella added a commit to esantorella/botorch that referenced this pull request Aug 17, 2023
@esantorella @facebook-github-bot
Even more fixes to unused kwargs (pytorch#1985)
0df0009 
Summary:
X-link: facebook/Ax#1782

Pull Request resolved: pytorch#1985

See previous diff

Reviewed By: lena-kashtelyan

Differential Revision: D48338443

fbshipit-source-id: 1ca14a55bf1e89b9c0d005b29d5ea7c7e16ee707
esantorella added a commit to esantorella/Ax that referenced this pull request Aug 17, 2023
@esantorella @facebook-github-bot
Even more fixes to unused kwargs (facebook#1782)
c3a5ef5 
Summary:
Pull Request resolved: facebook#1782

X-link: pytorch/botorch#1985

See previous diff

Reviewed By: lena-kashtelyan

Differential Revision: D48338443

fbshipit-source-id: 1e19efe7eb0504d61e0660dd57bacf07ba9366de
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48338443

esantorella added a commit to esantorella/botorch that referenced this pull request Aug 17, 2023
@esantorella @facebook-github-bot
Even more fixes to unused kwargs (pytorch#1985)
a577a6a 
Summary:
X-link: facebook/Ax#1782

Pull Request resolved: pytorch#1985

See previous diff

Reviewed By: lena-kashtelyan

Differential Revision: D48338443

fbshipit-source-id: e545697ad4f57c77388069a2b7531f2e5cb4f978
esantorella added a commit to esantorella/Ax that referenced this pull request Aug 17, 2023
@esantorella @facebook-github-bot
Even more fixes to unused kwargs (facebook#1782)
7811fac 
Summary:
Pull Request resolved: facebook#1782

X-link: pytorch/botorch#1985

See previous diff

Reviewed By: lena-kashtelyan

Differential Revision: D48338443

fbshipit-source-id: 022be0195dc74475d38ec32a259a659838f633c1
@esantorella @facebook-github-bot
Even more fixes to unused kwargs (pytorch#1985)
35a6556 
Summary:
X-link: facebook/Ax#1782

Pull Request resolved: pytorch#1985

See previous diff

Reviewed By: lena-kashtelyan

Differential Revision: D48338443

fbshipit-source-id: 9be8248e069e6bf61c0e4bf999505d81640eefc1
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48338443

esantorella added a commit to esantorella/Ax that referenced this pull request Aug 17, 2023
@esantorella @facebook-github-bot
Even more fixes to unused kwargs (facebook#1782)
3f79fd0 
Summary:
Pull Request resolved: facebook#1782

X-link: pytorch/botorch#1985

See previous diff

Reviewed By: lena-kashtelyan

Differential Revision: D48338443

fbshipit-source-id: 857251059f06b856d5d31e25dfec236fc20543ec
facebook-github-bot pushed a commit to facebook/Ax that referenced this pull request Aug 18, 2023
@esantorella @facebook-github-bot
Even more fixes to unused kwargs (#1782)
c3f0cef 
Summary:
Pull Request resolved: #1782

X-link: pytorch/botorch#1985

See previous diff

Reviewed By: lena-kashtelyan

Differential Revision: D48338443

fbshipit-source-id: f5f674fe224cf5a1ef06a6de9cdad10dfda09382
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 814f522.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@esantorella @facebook-github-bot