AnalyticExpectedUtilityOfBestOption input constructor uses pref_model.dim #1955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D47826495 |
Codecov Report
@@ Coverage Diff @@
## main #1955 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 178 178
Lines 15747 15747
=========================================
Hits 15747 15747
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ItsMrLin
added a commit
to ItsMrLin/botorch
that referenced
this pull request
Jul 27, 2023
….dim (pytorch#1955) Summary: Pull Request resolved: pytorch#1955 Make AnalyticExpectedUtilityOfBestOption input constructor uses `pref_model.dim` instead of `model.num_outputs` as the latter may also depend on the number of tasks for MTGPs. And example is a model list of MTGPs will have `model.num_outputs = num_tasks * num_outcomes` while we only want `num_outcomes` here. Differential Revision: D47826495 fbshipit-source-id: b3e1082d09c14f01484f2b034356a5b5e8ccb140
ItsMrLin
force-pushed
the
export-D47826495
branch
from
f8b653f to
07a0812
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47826495 |
ItsMrLin
added a commit
to ItsMrLin/botorch
that referenced
this pull request
Jul 27, 2023
….dim (pytorch#1955) Summary: Pull Request resolved: pytorch#1955 Make AnalyticExpectedUtilityOfBestOption input constructor uses `pref_model.dim` instead of `model.num_outputs` as the latter may also depend on the number of tasks for MTGPs. And example is a model list of MTGPs will have `model.num_outputs = num_tasks * num_outcomes` while we only want `num_outcomes` here. Differential Revision: D47826495 fbshipit-source-id: 02160b20ea3b7777912662015b643918b2778a60
ItsMrLin
force-pushed
the
export-D47826495
branch
from
07a0812 to
6bd37b3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47826495 |
….dim (pytorch#1955) Summary: Pull Request resolved: pytorch#1955 Make AnalyticExpectedUtilityOfBestOption input constructor uses `pref_model.dim` instead of `model.num_outputs` as the latter may also depend on the number of tasks for MTGPs. And example is a model list of MTGPs will have `model.num_outputs = num_tasks * num_outcomes` while we only want `num_outcomes` here. Differential Revision: D47826495 fbshipit-source-id: 11b64b1973e76aa32107ff1b5bacfc0891d575e4
ItsMrLin
force-pushed
the
export-D47826495
branch
from
6bd37b3 to
fbddc5a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47826495 |
|
This pull request has been merged in 2e92571. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Make AnalyticExpectedUtilityOfBestOption input constructor uses
pref_model.diminstead ofmodel.num_outputsas the latter may also depend on the number of tasks for MTGPs. And example is a model list of MTGPs will havemodel.num_outputs = num_tasks * num_outcomeswhile we only wantnum_outcomeshere.Differential Revision: D47826495