Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding qLog(N)EI to get_acquisition_function #1941

Closed
wants to merge 1 commit into from

Conversation

SebastianAment
Copy link
Contributor

Summary: This is used by the legacy model setup on the Ax side.

Differential Revision: D47633151

@facebook-github-bot facebook-github-bot added CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported labels Jul 20, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47633151

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #1941 (3e74927) into main (71fd34e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 3e74927 differs from pull request most recent head 7e37fb7. Consider uploading reports for the commit 7e37fb7 to get more accurate results

@@           Coverage Diff           @@
##             main    #1941   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files         177      177           
  Lines       15683    15689    +6     
=======================================
+ Hits        15675    15681    +6     
  Misses          8        8           
Files Changed Coverage Δ
botorch/acquisition/utils.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

SebastianAment added a commit to SebastianAment/botorch that referenced this pull request Jul 25, 2023
Summary:
Pull Request resolved: pytorch#1941

This is used by the legacy model setup on the Ax side.

Reviewed By: esantorella

Differential Revision: D47633151

fbshipit-source-id: 211d80dcac02c26f8a6a11035910b6dc8beffcfd
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47633151

SebastianAment added a commit to SebastianAment/botorch that referenced this pull request Jul 25, 2023
Summary:
Pull Request resolved: pytorch#1941

This is used by the legacy model setup on the Ax side.

Reviewed By: esantorella

Differential Revision: D47633151

fbshipit-source-id: 857632a04fe910b24fcaa3d8639e818310ab7bf7
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47633151

SebastianAment added a commit to SebastianAment/botorch that referenced this pull request Jul 25, 2023
Summary:
Pull Request resolved: pytorch#1941

This is used by the legacy model setup on the Ax side.

Reviewed By: esantorella

Differential Revision: D47633151

fbshipit-source-id: 5b7e2eeccbe8c085468ed1948bf36614939ccad1
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47633151

Summary:
Pull Request resolved: pytorch#1941

This is used by the legacy model setup on the Ax side.

Reviewed By: esantorella

Differential Revision: D47633151

fbshipit-source-id: 3a9726dbb362b8bb69c24f27950f11b8561e1ea9
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47633151

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 2e62b95.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants