Enabling SampleReducingMCAcquisitionFunctions with constraints in input_constructors
#1932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D47365084 |
SebastianAment
added a commit
to SebastianAment/botorch
that referenced
this pull request
Jul 11, 2023
…input_constructors` (pytorch#1932) Summary: Pull Request resolved: pytorch#1932 This commit enables the prinicpled constraint treatment via `SampleReducingMCAcquisitionFunctions` through `input_constructors` and `get_acquisition_function`. Differential Revision: D47365084 fbshipit-source-id: 016278c356cc02206de0fbeed5cdac0a2cf66c8d
SebastianAment
force-pushed
the
export-D47365084
branch
from
2f63bc9 to
4c595f4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47365084 |
SebastianAment
added a commit
to SebastianAment/botorch
that referenced
this pull request
Jul 12, 2023
…input_constructors` (pytorch#1932) Summary: Pull Request resolved: pytorch#1932 This commit enables the prinicpled constraint treatment via `SampleReducingMCAcquisitionFunctions` through `input_constructors` and `get_acquisition_function`. Differential Revision: D47365084 fbshipit-source-id: bea958703cdc85d9c3fad9d6b35aae5db884ee5e
SebastianAment
force-pushed
the
export-D47365084
branch
from
4c595f4 to
94b5dac
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47365084 |
SebastianAment
added a commit
to SebastianAment/botorch
that referenced
this pull request
Jul 12, 2023
…input_constructors` (pytorch#1932) Summary: Pull Request resolved: pytorch#1932 This commit enables the prinicpled constraint treatment via `SampleReducingMCAcquisitionFunctions` through `input_constructors` and `get_acquisition_function`. Differential Revision: D47365084 fbshipit-source-id: 50ef5e27e17ea2d0774bc32f97a20759d776e476
SebastianAment
force-pushed
the
export-D47365084
branch
from
94b5dac to
caa78be
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47365084 |
Codecov Report
@@ Coverage Diff @@
## main #1932 +/- ##
=======================================
Coverage 99.94% 99.94%
=======================================
Files 176 176
Lines 15480 15500 +20
=======================================
+ Hits 15472 15492 +20
Misses 8 8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Summary: Pull Request resolved: pytorch#1931 This commit separates out the `compute_best_feasible_f` function from `qNEI` as a utility function in order to use it in the `input_constructors` and `get_acquisition_function` (follow-up). Differential Revision: https://internalfb.com/D47365085 fbshipit-source-id: 4b89d25c02b7ac5d56a219b8d15dd4dd17599acf
…input_constructors` (pytorch#1932) Summary: Pull Request resolved: pytorch#1932 This commit enables the prinicpled constraint treatment via `SampleReducingMCAcquisitionFunctions` through `input_constructors` and `get_acquisition_function`. Reviewed By: esantorella Differential Revision: D47365084 fbshipit-source-id: 3688841ddb37fbbfab405a33077a838bd64a0ace
SebastianAment
force-pushed
the
export-D47365084
branch
from
caa78be to
03f7a30
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47365084 |
SebastianAment
added a commit
to SebastianAment/botorch
that referenced
this pull request
Jul 13, 2023
…input_constructors` (pytorch#1932) Summary: Pull Request resolved: pytorch#1932 This commit enables the prinicpled constraint treatment via `SampleReducingMCAcquisitionFunctions` through `input_constructors` and `get_acquisition_function`. Differential Revision: https://internalfb.com/D47365084 fbshipit-source-id: 0af2a9e3c046262a2c988251c8776407e7a0aa91
SebastianAment
added a commit
to SebastianAment/botorch
that referenced
this pull request
Jul 13, 2023
…input_constructors` (pytorch#1932) Summary: Pull Request resolved: pytorch#1932 This commit enables the prinicpled constraint treatment via `SampleReducingMCAcquisitionFunctions` through `input_constructors` and `get_acquisition_function`. Differential Revision: https://internalfb.com/D47365084 fbshipit-source-id: 6422ddeabde2cd9804b1e76e25236e2021f8c1a2
|
This pull request has been merged in ef5a939. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This commit enables the prinicpled constraint treatment via
SampleReducingMCAcquisitionFunctionsthroughinput_constructorsandget_acquisition_function.Differential Revision: D47365084