Batch-MC Prior-Guided AF #1925
Closed
Batch-MC Prior-Guided AF #1925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D47307059 |
Codecov Report
@@ Coverage Diff @@
## main #1925 +/- ##
=======================================
Coverage 99.94% 99.94%
=======================================
Files 176 176
Lines 15459 15467 +8
=======================================
+ Hits 15451 15459 +8
Misses 8 8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sdaulton
added a commit
to sdaulton/botorch
that referenced
this pull request
Jul 11, 2023
Summary: Pull Request resolved: pytorch#1925 see title. This weights the AF values before reduction over the sample and q-dims. This also handles `X_pending` directly, rather than on the underlying AF. This ensures, `X_pending` is concatenated with `X` and passed to both the AF an the prior. This will only work for AFs that support concatenating `X_pending`. This would need revision to work with for example NEHVI with cached box decompositions. Reviewed By: Balandat Differential Revision: D47307059 fbshipit-source-id: 92499a9b9b99878b8f9ea38757cbed1dc02f77c2
sdaulton
force-pushed
the
export-D47307059
branch
from
ff75781 to
981edf6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47307059 |
Summary: See title. This is used in the stacked diff. Differential Revision: D47296866 fbshipit-source-id: 1ace485d1434d856cd3c15f1515756a0f39c76e9
Summary: Pull Request resolved: pytorch#1925 see title. This weights the AF values before reduction over the sample and q-dims. This also handles `X_pending` directly, rather than on the underlying AF. This ensures, `X_pending` is concatenated with `X` and passed to both the AF an the prior. This will only work for AFs that support concatenating `X_pending`. This would need revision to work with for example NEHVI with cached box decompositions. Reviewed By: Balandat Differential Revision: D47307059 fbshipit-source-id: 0f7567a6036928c4df82068d809c947fb0f92a61
sdaulton
force-pushed
the
export-D47307059
branch
from
981edf6 to
26a68bd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47307059 |
|
This pull request has been merged in 48afca1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
see title. This weights the AF values before reduction over the sample and q-dims.
This also handles
X_pendingdirectly, rather than on the underlying AF. This ensures,X_pendingis concatenated withXand passed to both the AF an the prior. This will only work for AFs that support concatenatingX_pending.This would need revision to work with for example NEHVI with cached box decompositions.
Reviewed By: Balandat
Differential Revision: D47307059