Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LinearEllipticalSliceSampler with non-standard Normals #1879

Closed
wants to merge 2 commits into from

Conversation

SebastianAment
Copy link
Contributor

Summary: This commit adds support for non-standard Normal base distributions in the LinearEllipticalSliceSampler. The approach standardizes the problem internally by modifying the constraint system.

Reviewed By: Balandat

Differential Revision: D46579587

@facebook-github-bot facebook-github-bot added CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported labels Jun 9, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46579587

@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #1879 (a80fc4d) into main (ef52ea9) will not change coverage.
The diff coverage is 100.00%.

❗ Current head a80fc4d differs from pull request most recent head 7bc51d7. Consider uploading reports for the commit 7bc51d7 to get more accurate results

@@            Coverage Diff            @@
##              main     #1879   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          172       172           
  Lines        15111     15134   +23     
=========================================
+ Hits         15111     15134   +23     
Impacted Files Coverage Δ
botorch/utils/probability/lin_ess.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

SebastianAment added a commit to SebastianAment/botorch that referenced this pull request Jun 9, 2023
Summary:
Pull Request resolved: pytorch#1879

This commit adds support for non-standard Normal base distributions in the LinearEllipticalSliceSampler. The approach standardizes the problem internally by modifying the constraint system.

Reviewed By: Balandat

Differential Revision: D46579587

fbshipit-source-id: f49c941bf8b334302c6ec7cc7ae5883dce857e70
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46579587

SebastianAment and others added 2 commits June 9, 2023 11:03
Summary: This commit introduces burn-in and thinning for the linear elliptical slice sampler.

Differential Revision: https://internalfb.com/D46532855

fbshipit-source-id: a5d74c0c72f1a97d84c93c00685b541561ef3c5d
Summary:
Pull Request resolved: pytorch#1879

This commit adds support for non-standard Normal base distributions in the LinearEllipticalSliceSampler. The approach standardizes the problem internally by modifying the constraint system.

Reviewed By: Balandat

Differential Revision: D46579587

fbshipit-source-id: 09cc5ea6e5496d99ee71de871e7857f7e320bed3
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46579587

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in e2caef4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants