Fix PairwiseGP comparisons might be implicitly modified #1811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D45472153 |
Codecov Report
@@ Coverage Diff @@
## main #1811 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 170 170
Lines 14913 14913
=========================================
Hits 14913 14913
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ItsMrLin
added a commit
to ItsMrLin/botorch
that referenced
this pull request
May 2, 2023
Summary: Pull Request resolved: pytorch#1811 Fix the bug where the unconsolidated comparisons might be implicitly modified modified when calling forward. This is because `self.comparisons` is passed into `set_train_data` in `forward`, which itself might already been consolidated/deduped. Reviewed By: qingfeng10 Differential Revision: D45472153 fbshipit-source-id: 97aef3517d35d36293d0f13ff3503c3fcdc692c5
|
This pull request was exported from Phabricator. Differential Revision: D45472153 |
ItsMrLin
added a commit
to ItsMrLin/botorch
that referenced
this pull request
May 3, 2023
Summary: Pull Request resolved: pytorch#1811 Fix the bug where the unconsolidated comparisons might be implicitly modified modified when calling forward. This is because `self.comparisons` is passed into `set_train_data` in `forward`, which itself might already been consolidated/deduped. Reviewed By: qingfeng10 Differential Revision: D45472153 fbshipit-source-id: d2e73074650b4a9c77d7fcc7f3e04958a13acee3
|
This pull request was exported from Phabricator. Differential Revision: D45472153 |
ItsMrLin
added a commit
to ItsMrLin/botorch
that referenced
this pull request
May 3, 2023
Summary: Pull Request resolved: pytorch#1811 Fix the bug where the unconsolidated comparisons might be implicitly modified modified when calling forward. This is because `self.comparisons` is passed into `set_train_data` in `forward`, which itself might already been consolidated/deduped. Reviewed By: qingfeng10 Differential Revision: D45472153 fbshipit-source-id: 9029aab797bf89de8d2ec18d4be09db195717c83
|
This pull request was exported from Phabricator. Differential Revision: D45472153 |
ItsMrLin
added a commit
to ItsMrLin/botorch
that referenced
this pull request
May 3, 2023
Summary: Pull Request resolved: pytorch#1811 Fix the bug where the unconsolidated comparisons might be implicitly modified modified when calling forward. This is because `self.comparisons` is passed into `set_train_data` in `forward`, which itself might already been consolidated/deduped. Reviewed By: qingfeng10 Differential Revision: D45472153 fbshipit-source-id: 259415c8ae59200bae141135c8f690c9a3dd0880
|
This pull request was exported from Phabricator. Differential Revision: D45472153 |
ItsMrLin
added a commit
to ItsMrLin/botorch
that referenced
this pull request
May 3, 2023
Summary: Pull Request resolved: pytorch#1811 Fix the bug where the unconsolidated comparisons might be implicitly modified modified when calling forward. This is because `self.comparisons` is passed into `set_train_data` in `forward`, which itself might already been consolidated/deduped. Reviewed By: qingfeng10 Differential Revision: D45472153 fbshipit-source-id: 2457eaf2db1dd44924c17718d8e8c2b31a447929
|
This pull request was exported from Phabricator. Differential Revision: D45472153 |
ItsMrLin
added a commit
to ItsMrLin/botorch
that referenced
this pull request
May 3, 2023
Summary: Pull Request resolved: pytorch#1811 Fix the bug where the unconsolidated comparisons might be implicitly modified modified when calling forward. This is because `self.comparisons` is passed into `set_train_data` in `forward`, which itself might already been consolidated/deduped. Reviewed By: qingfeng10 Differential Revision: D45472153 fbshipit-source-id: 7f7659e277feed05fa405cd202aea5173351c617
|
This pull request was exported from Phabricator. Differential Revision: D45472153 |
Summary: Pull Request resolved: pytorch#1811 Fix the bug where the unconsolidated comparisons might be implicitly modified modified when calling forward. This is because `self.comparisons` is passed into `set_train_data` in `forward`, which itself might already been consolidated/deduped. Reviewed By: qingfeng10 Differential Revision: D45472153 fbshipit-source-id: e7dda1ecd5245f753a6dd67c7f13a31b375b5e49
|
This pull request was exported from Phabricator. Differential Revision: D45472153 |
|
This pull request has been merged in e7077a6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fix the bug where the unconsolidated comparisons might be implicitly modified modified when calling forward.
This is because
self.comparisonsis passed intoset_train_datainforward, which itself might already been consolidated/deduped.Reviewed By: qingfeng10
Differential Revision: D45472153