More informative error message when Standardize has wrong batch shape; fixed unit test #1807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…; fixed unit test Summary: - More informative error message when Standardize has wrong batch shape - `self.assertRaisesRegex(..., msg=)` doesn't check that the error message matches `msg`! Fixed a test that used this where the message actually did not match `msg`. Differential Revision: D45313942 fbshipit-source-id: 8d653fe99ff3f333504fffbdf43df8554054ee67
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D45313942 |
Codecov Report
@@ Coverage Diff @@
## main #1807 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 170 170
Lines 14912 14912
=========================================
Hits 14912 14912
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
This pull request has been merged in c3d100f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
self.assertRaisesRegex(..., msg=)doesn't check that the error message matchesmsg! Fixed a test that used this where the message actually did not matchmsg.Differential Revision: D45313942