Use prune_baseline=True as default for qNEI
#1796
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D45054740 |
Summary: Pull Request resolved: pytorch#1796 Without prune baseline, we waste a lot of compute in the forward pass since we need to compute the posterior for joint q-batch over X and X_baseline. Reviewed By: dme65, Balandat Differential Revision: D45054740 fbshipit-source-id: b9301d3a517db4f4276b65100cc8100fb802ec2d
|
This pull request was exported from Phabricator. Differential Revision: D45054740 |
saitcakmak
force-pushed
the
export-D45054740
branch
from
05b0386 to
22dce43
Compare
Codecov Report
@@ Coverage Diff @@
## main #1796 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 170 170
Lines 14779 14779
=========================================
Hits 14779 14779
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
This pull request has been merged in a58d034. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Without prune baseline, we waste a lot of compute in the forward pass since we need to compute the posterior for joint q-batch over X and X_baseline.
Reviewed By: dme65, Balandat
Differential Revision: D45054740