Don't do a BotorchTensorDimensionWarning when the dimensions are fine #1790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D45006263 |
Codecov Report
@@ Coverage Diff @@
## main #1790 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 170 170
Lines 14779 14779
=========================================
Hits 14779 14779
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Apr 14, 2023
…pytorch#1790) Summary: Pull Request resolved: pytorch#1790 The status quo behavior of `_validate_tensor_args` in non-strict mode is to raise an error regardless of whether there would have been an error in strict mode. This change makes it so that there is only a warning in non-strict mode when there would have been an error in strict mode Reviewed By: Balandat Differential Revision: D45006263 fbshipit-source-id: 366084a13c7247bd7e5463db812191fbb7e73f57
esantorella
force-pushed
the
export-D45006263
branch
from
15847d6 to
f02f1e1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45006263 |
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Apr 14, 2023
…pytorch#1790) Summary: Pull Request resolved: pytorch#1790 The status quo behavior of `_validate_tensor_args` in non-strict mode is to raise an error regardless of whether there would have been an error in strict mode. This change makes it so that there is only a warning in non-strict mode when there would have been an error in strict mode Reviewed By: Balandat Differential Revision: D45006263 fbshipit-source-id: cc3aad30df31f535d692facf34cb6f7b52e4cebd
esantorella
force-pushed
the
export-D45006263
branch
from
f02f1e1 to
0b8f8eb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45006263 |
…pytorch#1790) Summary: Pull Request resolved: pytorch#1790 The status quo behavior of `_validate_tensor_args` in non-strict mode is to raise an error regardless of whether there would have been an error in strict mode. This change makes it so that there is only a warning in non-strict mode when there would have been an error in strict mode Reviewed By: Balandat Differential Revision: D45006263 fbshipit-source-id: 46d7a314b880659dd7b99e7057e1f8452ca222e7
esantorella
force-pushed
the
export-D45006263
branch
from
0b8f8eb to
bc06ad8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45006263 |
|
This pull request has been merged in ee48d4a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The status quo behavior of
_validate_tensor_argsin non-strict mode is to raise an error regardless of whether there would have been an error in strict mode. This change makes it so that there is only a warning in non-strict mode when there would have been an error in strict modeReviewed By: Balandat
Differential Revision: D45006263