Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecating objective in favor of posterior_transform for MultiObjectiveAnalyticAcquisitionFunction #1781

Closed
wants to merge 1 commit into from

Conversation

SebastianAment
Copy link
Contributor

Summary: This commit deprecates AnalyticMultiOutputObjective and replaces it with a posterior transform.

Differential Revision: D43047711

@facebook-github-bot facebook-github-bot added CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported labels Apr 5, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43047711

SebastianAment added a commit to SebastianAment/botorch that referenced this pull request Apr 5, 2023
…bjectiveAnalyticAcquisitionFunction` (pytorch#1781)

Summary:
Pull Request resolved: pytorch#1781

This commit deprecates `AnalyticMultiOutputObjective` and replaces it with a posterior transform.

Differential Revision: D43047711

fbshipit-source-id: a635a3da3c0914073ef79a00dce28abed4f651cd
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43047711

SebastianAment added a commit to SebastianAment/botorch that referenced this pull request Apr 5, 2023
…bjectiveAnalyticAcquisitionFunction` (pytorch#1781)

Summary:
Pull Request resolved: pytorch#1781

This commit deprecates `AnalyticMultiOutputObjective` and replaces it with a posterior transform.

Differential Revision: D43047711

fbshipit-source-id: c7cab525fc9c57c9229c8023051de04568c46035
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43047711

@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Merging #1781 (62cfbf3) into main (0333cc4) will decrease coverage by 0.02%.
The diff coverage is 93.33%.

❗ Current head 62cfbf3 differs from pull request most recent head fdff938. Consider uploading reports for the commit fdff938 to get more accurate results

@@             Coverage Diff             @@
##              main    #1781      +/-   ##
===========================================
- Coverage   100.00%   99.98%   -0.02%     
===========================================
  Files          170      170              
  Lines        14760    14769       +9     
===========================================
+ Hits         14760    14767       +7     
- Misses           0        2       +2     
Impacted Files Coverage Δ
botorch/acquisition/objective.py 98.70% <88.23%> (-1.30%) ⬇️
botorch/acquisition/multi_objective/analytic.py 100.00% <100.00%> (ø)
botorch/acquisition/multi_objective/objective.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

SebastianAment added a commit to SebastianAment/botorch that referenced this pull request Apr 5, 2023
…bjectiveAnalyticAcquisitionFunction` (pytorch#1781)

Summary:
Pull Request resolved: pytorch#1781

This commit deprecates `AnalyticMultiOutputObjective` and replaces it with a posterior transform.

Differential Revision: D43047711

fbshipit-source-id: 7d6cdac8bcfb6c839c3bb1f61d8006065c1c0b94
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43047711

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43047711

SebastianAment added a commit to SebastianAment/botorch that referenced this pull request Apr 6, 2023
…bjectiveAnalyticAcquisitionFunction` (pytorch#1781)

Summary:
Pull Request resolved: pytorch#1781

This commit deprecates `AnalyticMultiOutputObjective` and replaces it with a posterior transform.

Reviewed By: Balandat

Differential Revision: D43047711

fbshipit-source-id: b06b636b1a5d614bb9f1610e66fd229a8f88d655
SebastianAment added a commit to SebastianAment/botorch that referenced this pull request Apr 6, 2023
…bjectiveAnalyticAcquisitionFunction` (pytorch#1781)

Summary:
Pull Request resolved: pytorch#1781

This commit deprecates `AnalyticMultiOutputObjective` and replaces it with a posterior transform.

Reviewed By: Balandat

Differential Revision: D43047711

fbshipit-source-id: 8a7aac6c293ea67098c5b81b45d4d04eb5b7d9f0
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43047711

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43047711

SebastianAment added a commit to SebastianAment/botorch that referenced this pull request Apr 6, 2023
…bjectiveAnalyticAcquisitionFunction` (pytorch#1781)

Summary:
Pull Request resolved: pytorch#1781

This commit deprecates `AnalyticMultiOutputObjective` and replaces it with a posterior transform.

Reviewed By: Balandat

Differential Revision: D43047711

fbshipit-source-id: b6e7592cb255abcfe13395dadf5beb5d4922de51
…bjectiveAnalyticAcquisitionFunction` (pytorch#1781)

Summary:
Pull Request resolved: pytorch#1781

This commit deprecates `AnalyticMultiOutputObjective` and replaces it with a posterior transform.

Reviewed By: Balandat

Differential Revision: D43047711

fbshipit-source-id: 1f038364985bfd0e8588bf98399ebb39af7b04ab
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43047711

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in e6bb147.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants