Remove Fully Bayesian logic in low_rank #1773
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D44634780 |
Balandat
added a commit
to Balandat/botorch
that referenced
this pull request
Apr 4, 2023
Summary: Pull Request resolved: pytorch#1773 Remove the fully Bayesian specialty logic (previously necessary to deal with non-standard batch ranges). Reviewed By: sdaulton Differential Revision: D44634780 fbshipit-source-id: 3e38200e00d3d057c3cf89a580fd921a80fd3b5c
Balandat
force-pushed
the
export-D44634780
branch
from
f60fc0c to
0005e41
Compare
|
This pull request was exported from Phabricator. Differential Revision: D44634780 |
Differential Revision: D44599898 fbshipit-source-id: 2ec020ac8d7c23dbfd5b505de782bd2c544413af
Summary: Pull Request resolved: pytorch#1773 Remove the fully Bayesian specialty logic (previously necessary to deal with non-standard batch ranges). Reviewed By: sdaulton Differential Revision: D44634780 fbshipit-source-id: 789f01ec2c89cefbd448ed36934a8a7792eefcd6
|
This pull request was exported from Phabricator. Differential Revision: D44634780 |
Balandat
force-pushed
the
export-D44634780
branch
from
0005e41 to
b6dfb7a
Compare
Codecov Report
@@ Coverage Diff @@
## main #1773 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 170 170
Lines 14762 14760 -2
=========================================
- Hits 14762 14760 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
This pull request has been merged in ae7ceb9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the batch range of FullyBayesianPosterior, which effectively means that we will regard the MC batch as a t-batch for the purposes of sampling. Also remove the fully Bayesian specialty logic (previously necessary to deal with non-standard batch ranges).
Reviewed By: sdaulton
Differential Revision: D44634780