Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up scbo tutorial #1742

Closed
wants to merge 2 commits into from
Closed

Conversation

dme65
Copy link
Contributor

@dme65 dme65 commented Mar 15, 2023

Use 2000 instead of 4000 candidates in order to lower the memory usage and also make the tutorial run faster

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Mar 15, 2023
@facebook-github-bot
Copy link
Contributor

@dme65 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Merging #1742 (4c898f3) into main (7a04fec) will not change coverage.
The diff coverage is n/a.

❗ Current head 4c898f3 differs from pull request most recent head 48d7283. Consider uploading reports for the commit 48d7283 to get more accurate results

@@            Coverage Diff            @@
##              main     #1742   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          170       170           
  Lines        14636     14636           
=========================================
  Hits         14636     14636           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@Balandat Balandat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@facebook-github-bot
Copy link
Contributor

@dme65 merged this pull request in 7326f6d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants