Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lower memory usage in CAS tutorial #1739

Closed
wants to merge 1 commit into from
Closed

Lower memory usage in CAS tutorial #1739

wants to merge 1 commit into from

Conversation

dme65
Copy link
Contributor

@dme65 dme65 commented Mar 14, 2023 •
edited
Loading

The CAS tutorial has been running into OOMs in the CI. This lowers the memory usage by using fewer samples in the ECI acquisition function.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Mar 14, 2023
@facebook-github-bot
Copy link
Contributor

@dme65 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Balandat
Balandat approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@Balandat Balandat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - can you also add the main changes to the summary? Kind of hard to spot given that this is edited in the json.

@facebook-github-bot
Copy link
Contributor

@dme65 merged this pull request in d6c9d3b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Balandat Balandat Balandat approved these changes

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dme65 @facebook-github-bot @Balandat