Fix get_infeasible_cost for objectives that require X

[jduerholt]

Motivation

The method get_infeasible_cost is currently not able to also handle objectives that require also X values, which will be the new default in one of the next releases. This PR fixes it.

Have you read the Contributing Guidelines on pull requests?

Yes.

Test Plan

Unit tests.

[codecov]

Codecov Report

Merging #1721 (463f349) into main (ba90c9b) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 463f349 differs from pull request most recent head a2cf481. Consider uploading reports for the commit a2cf481 to get more accurate results

@@            Coverage Diff            @@
##              main     #1721   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          170       170           
  Lines        14621     14621           
=========================================
  Hits         14621     14621           

Impacted Files	Coverage Δ
botorch/acquisition/input_constructors.py	100.00% <ø> (ø)
botorch/acquisition/multi_objective/objective.py	100.00% <ø> (ø)
botorch/acquisition/utils.py	100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[jduerholt]

@saitcakmak @Balandat any thoughts on this? ;)

[Balandat]

This makes sense to me - could you add a unit tests that checks the new behavior of get_infeasible_cost if the objective indeed does depend on X? Thanks!

[jduerholt]

This makes sense to me - could you add a unit tests that checks the new behavior of get_infeasible_cost if the objective indeed does depend on X? Thanks!

Yes, I will add something!

[jduerholt]

I just added a test, hope it is fine now ;)

[facebook-github-bot]

@Balandat has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[Balandat]

great, lgtm! Thanks for the fix.

[facebook-github-bot]

@Balandat merged this pull request in 4a76513.