Re-run MOMF tutorial and make it look nicer #1718
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: I am about to make more substantive changes to this tutorial in a subsequent diff. To make that future diff easier to review, I made some hopefully-less-controversial changes and re-ran the tutorial first. - Added %%time to a couple cells, and tqdm progress bars, removed print statements tracking how far iteration has gotten - Removed unused function arguments - Tidied up odd-looking formatting of comments and docstrings - Set seed so it's the same every time (which will be useful when confirming the speed-ups in the next diff don't make things worse) - Ran it Differential Revision: D43708102 fbshipit-source-id: 05d18ef00efe7014aa4cd489203e83928688f013
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D43708102 |
Codecov Report
@@ Coverage Diff @@
## main #1718 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 170 170
Lines 14621 14621
=========================================
Hits 14621 14621 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I am about to make more substantive changes to this tutorial in a subsequent diff. To make that future diff easier to review, I made some hopefully-less-controversial changes and re-ran the tutorial first.
Differential Revision: D43708102