Improve batched model handling in _verify_output_shape #1715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Previously, this would error out if X was getting broadcasted to the model batch shape. Fixes pytorch#1712 Differential Revision: D43708320 fbshipit-source-id: cdbba22dff686707af26bf24d8711548bf890152
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D43708320 |
Codecov Report
@@ Coverage Diff @@
## main #1715 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 170 170
Lines 14610 14621 +11
=========================================
+ Hits 14610 14621 +11
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
This pull request has been merged in 44894c6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Previously, this would error out if X was getting broadcasted to the model batch shape. Fixes #1712
Differential Revision: D43708320