Run black on tutorials #1711
Closed
Run black on tutorials #1711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Codecov Report
@@ Coverage Diff @@
## main #1711 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 170 170
Lines 14610 14610
=========================================
Hits 14610 14610 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@esantorella has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@esantorella merged this pull request in ba90c9b. |
facebook-github-bot
pushed a commit
to facebook/Ax
that referenced
this pull request
Mar 7, 2023
Summary: Same as pytorch/botorch#1711 * Prevents people from accidentally making a large diff while making a small change with an editor that auto-formats code * Makes things look nicer and more consistent, especially breaking pu some very long lines Pull Request resolved: #1485 Test Plan: I'm looking over the changed tutorials Reviewed By: danielcohenlive Differential Revision: D43772736 Pulled By: esantorella fbshipit-source-id: 8786b9211e04153aeed9d6d1c82340825a83172d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I am working on fixing up some tutorials. Since I and others work in editors which may auto-reformat code, it is easy to accidentally make a large diff while making a small change, which makes pull requests hard to review. This PR only runs black (with notebook dependencies:
pip install black[jupyter]).Also, this makes formatting a bit nicer -- for example consistently using double quotes and removing some extremely long lines.
Test Plan
I am actually looking at all of the notebooks.