Allow tensor input for integer_indices in Round transform #1709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This simplifies storage in Ax. Without this change, `integer_indices = integer_indices or []` raises an error with tensors. Differential Revision: D43649436 fbshipit-source-id: f4195026911d18d0b61a6f1adde9d7b60d442cd7
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D43649436 |
Codecov Report
@@ Coverage Diff @@
## main #1709 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 170 170
Lines 14610 14610
=========================================
Hits 14610 14610
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
This pull request has been merged in 28788ba. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This simplifies storage in Ax. Without this change,
integer_indices = integer_indices or []raises an error with tensors.Differential Revision: D43649436