[Easy] 5-minute timeout for smoke test tutorials #1707
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@esantorella has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
saitcakmak
approved these changes
Feb 27, 2023
Codecov Report
@@ Coverage Diff @@
## main #1707 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 170 170
Lines 14610 14610
=========================================
Hits 14610 14610 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Co-authored-by: Sait Cakmak <saitcakmak@outlook.com>
|
@esantorella has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@esantorella merged this pull request in 10b35f9. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 28, 2023
Summary: ## Motivation Some tutorials were being ignored both in "smoke test" and "standard" runs because they OOM or time out in standard runs, but they actually run fine in "smoke test" mode. I moved those three tutorials to the list now called `RUN_IF_SMOKE_TEST_IGNORE_IF_STANDARD` (renamed for clarity). Pull Request resolved: #1708 Test Plan: Ran locally; should run in CI ## Related PRs Depends on #1707 (add five-minute timeout for smoke test tutorials) Reviewed By: saitcakmak Differential Revision: D43637457 Pulled By: esantorella fbshipit-source-id: 6f5f1f02bd381f552944763ba8f697cc2cafc8a7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, all tutorials time out at 30 minutes. We want smoke test tutorials to take much less time than that, and currently they all run in under 3.5 minutes, and most run much faster than that (see here). As we work to get more tutorials online, it would be good to a have a clear idea of what is fast enough for a smoke-test tutorial run.
Test Plan
Checked that it ran locally; unit tests