[RFC] Use papermill for running tutorials #1705
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We are using nbconvert to run tutorials. nbconvert is not really made for this use case, but papermill is, so we have some handwritten LOC than can be handled by papermill. With papermill, we can go a bit further and use SMOKE_TEST as a parameter rather than an environment variable. That would make it easy for people to work with the tutorials as notebooks.
Test Plan
Ran tutorials locally and made sure smoke-test flag was getting used appropriately.
Related pull requests
Enabling papermill will make #1703, which automates running a notebook, a bit easier.