Require torch >= 1.12 #1699
Closed
Require torch >= 1.12 #1699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: In `test/utils/probability/test_utils.py`, we compare `log_ndtr` implementation with `torch.special.log_ndtr`, which is was introduced in 1.12. Reviewed By: esantorella Differential Revision: D43545624 fbshipit-source-id: 6f9e9a18b2d4a5c1bba4edcc2dcf8d861ec781db
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D43545624 |
Codecov Report
@@ Coverage Diff @@
## main #1699 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 169 169
Lines 14555 14555
=========================================
Hits 14555 14555 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
This pull request has been merged in 1c0747c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: In
test/utils/probability/test_utils.py, we comparelog_ndtrimplementation withtorch.special.log_ndtr, which is was introduced in 1.12.Reviewed By: esantorella
Differential Revision: D43545624