Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EUBO optimization error when two Xs are identical #1670

Closed
wants to merge 1 commit into from

Conversation

ItsMrLin
Copy link
Contributor

Summary: Fixing 0/0 problem in EUBO when the two Xs are identical

Differential Revision: D43204789

@facebook-github-bot facebook-github-bot added CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported labels Feb 10, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43204789

@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Merging #1670 (54c0614) into main (36d09a4) will not change coverage.
The diff coverage is n/a.

❗ Current head 54c0614 differs from pull request most recent head b2a1061. Consider uploading reports for the commit b2a1061 to get more accurate results

@@            Coverage Diff            @@
##              main     #1670   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          166       166           
  Lines        14371     14371           
=========================================
  Hits         14371     14371           
Impacted Files Coverage Δ
botorch/acquisition/preference.py 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Summary:
Pull Request resolved: pytorch#1670

Fixing 0/0 problem in EUBO when the two Xs are identical

Reviewed By: qingfeng10

Differential Revision: D43204789

fbshipit-source-id: 4de189cda14c7f50fae66fa188eb6b50299d48f2
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43204789

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 4445045.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants