Clean up optimize_acqf and _make_linear_constraints #1660
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D43012356 |
esantorella
force-pushed
the
export-D43012356
branch
from
3668bc4 to
1bc3727
Compare
|
This pull request was exported from Phabricator. Differential Revision: D43012356 |
Codecov Report
@@ Coverage Diff @@
## main #1660 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 166 166
Lines 14371 14422 +51
=========================================
+ Hits 14371 14422 +51
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Feb 8, 2023
Summary: Pull Request resolved: pytorch#1660 Bot was rightly complaining about complexity - pulled out method to validate inputs for `_make_linear_constraints` - introduced a dataclass to contain and validate the inputs for `optimize_acqf` - `optimize_acqf` now calls one of three different `optimize_acqf_[name]` functions Differential Revision: D43012356 fbshipit-source-id: 999c01a391c84d4b002978b0282caa84c2622bfa
esantorella
force-pushed
the
export-D43012356
branch
from
1bc3727 to
aadc9b6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D43012356 |
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Feb 10, 2023
Summary: Pull Request resolved: pytorch#1660 Bot was rightly complaining about complexity - pulled out method to validate inputs for `_make_linear_constraints` - introduced a dataclass to contain and validate the inputs for `optimize_acqf` - `optimize_acqf` now calls one of three different `optimize_acqf_[name]` functions Reviewed By: Balandat Differential Revision: D43012356 fbshipit-source-id: 8687b1f4d649dd32cd3d9a0905193843ce16942d
esantorella
force-pushed
the
export-D43012356
branch
from
aadc9b6 to
1b432ec
Compare
|
This pull request was exported from Phabricator. Differential Revision: D43012356 |
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Feb 10, 2023
Summary: Pull Request resolved: pytorch#1660 Bot was rightly complaining about complexity - pulled out method to validate inputs for `_make_linear_constraints` - introduced a dataclass to contain and validate the inputs for `optimize_acqf` - `optimize_acqf` now calls one of three different `optimize_acqf_[name]` functions Reviewed By: Balandat Differential Revision: D43012356 fbshipit-source-id: 861b4574373a53820d4cc35840c54fceac155e85
esantorella
force-pushed
the
export-D43012356
branch
from
1b432ec to
57ef6b7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D43012356 |
Summary: Pull Request resolved: pytorch#1660 Bot was rightly complaining about complexity - pulled out method to validate inputs for `_make_linear_constraints` - introduced a dataclass to contain and validate the inputs for `optimize_acqf` - `optimize_acqf` now calls one of three different `optimize_acqf_[name]` functions Reviewed By: Balandat Differential Revision: D43012356 fbshipit-source-id: 25833cadaf1862a706cfb805f14446dd3dc90a34
esantorella
force-pushed
the
export-D43012356
branch
from
57ef6b7 to
c818d69
Compare
|
This pull request was exported from Phabricator. Differential Revision: D43012356 |
|
This pull request has been merged in aa38ac4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Bot was rightly complaining about complexity
Differential Revision: D43012356