Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding logmeanexp and logdiffexp numerical utilities #1657

Closed
wants to merge 1 commit into from

Conversation

SebastianAment
Copy link
Contributor

Summary: This commit defines logdiffexp and logmeanexp, numerical utility functions that are going to be more generally useful for log-space computations.

Differential Revision: D43061278

@facebook-github-bot facebook-github-bot added CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported labels Feb 7, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43061278

@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Merging #1657 (9b76014) into main (d026e80) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main     #1657   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          165       166    +1     
  Lines        14284     14352   +68     
=========================================
+ Hits         14284     14352   +68     
Impacted Files Coverage Δ
botorch/models/transforms/utils.py 100.00% <ø> (ø)
botorch/acquisition/analytic.py 100.00% <100.00%> (ø)
botorch/models/transforms/__init__.py 100.00% <100.00%> (ø)
botorch/models/transforms/factory.py 100.00% <100.00%> (ø)
botorch/models/transforms/input.py 100.00% <100.00%> (ø)
botorch/utils/probability/utils.py 100.00% <100.00%> (ø)
botorch/utils/safe_math.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Summary:
Pull Request resolved: pytorch#1657

This commit defines `logdiffexp` and `logmeanexp`, numerical utility functions that are going to be more generally useful for log-space computations.

Reviewed By: Balandat

Differential Revision: D43061278

fbshipit-source-id: 737ee539d34d3bf09dcf6e46df5f3fcbad90a112
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43061278

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in ffcad4a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants