Don't use functools.lru_cache on methods #1650
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D42980747 |
Codecov Report
@@ Coverage Diff @@
## main #1650 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 165 165
Lines 14277 14284 +7
=========================================
+ Hits 14277 14284 +7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Summary: Pull Request resolved: pytorch#1650 It can cause memory leaks. For explanation and fix, see https://rednafi.github.io/reflections/dont-wrap-instance-methods-with-functoolslru_cache-decorator-in-python.html Differential Revision: D42980747 fbshipit-source-id: 8b780d2679bac46de9c0081d59123ee62f791436
|
This pull request was exported from Phabricator. Differential Revision: D42980747 |
esantorella
force-pushed
the
export-D42980747
branch
from
b83f33e to
4b0e35c
Compare
|
This pull request has been merged in 7e1350b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
It can cause memory leaks. For explanation
and fix, see https://rednafi.github.io/reflections/dont-wrap-instance-methods-with-functoolslru_cache-decorator-in-python.html
Differential Revision: D42980747