Warn when optimizer kwargs are being ignored in BoTorch optim utils _filter_kwargs
#1645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_filter_kwargs` Summary: The HOGP tutorial was using kwargs 'maxiter' and 'disp' that were being silently ignored since the Adam optimizer doesn't take those arguments. Reviewed By: saitcakmak Differential Revision: D42729349 fbshipit-source-id: e4360606bbc13ff0312eb0a4c15a14608115b4dd
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D42729349 |
Codecov Report
@@ Coverage Diff @@
## main #1645 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 155 155
Lines 13784 13788 +4
=========================================
+ Hits 13784 13788 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
This pull request has been merged in 2a4baa1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The HOGP tutorial was using kwargs 'maxiter' and 'disp' that were being silently ignored since the Adam optimizer doesn't take those arguments.
Reviewed By: saitcakmak
Differential Revision: D42729349