Detach coefficient and offset in AffineTransform #1642
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D42700421 |
Codecov Report
@@ Coverage Diff @@
## main #1642 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 155 155
Lines 13788 13796 +8
=========================================
+ Hits 13788 13796 +8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
See #1635 (comment) for an explanation of why I think gradient information should flow through |
…h#1642) Summary: Pull Request resolved: pytorch#1642 See pytorch#1635. These should only retain grad if learning the coefficient and while in train mode. Differential Revision: D42700421 fbshipit-source-id: 907f72a6f585f55f1496e23f58bc463eac063860
|
This pull request was exported from Phabricator. Differential Revision: D42700421 |
saitcakmak
force-pushed
the
export-D42700421
branch
from
8026e60 to
816425e
Compare
|
This pull request has been merged in de31154. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: See #1635. These should only retain grad if learning the coefficient and while in train mode.
Differential Revision: D42700421