Do not filter out BoTorchWarnings by default #1630
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D42017622 |
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Jan 14, 2023
Summary: Pull Request resolved: pytorch#1630 Updates `debug` flag to be an opt-in only. Previously this was filtering out all BoTorchWarnings, which significantly limited usage of these warnings. Differential Revision: D42017622 fbshipit-source-id: 9d46140150b896a40eb058310677aacd7005e6da
saitcakmak
force-pushed
the
export-D42017622
branch
from
06dcf38 to
413dfa0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D42017622 |
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Jan 14, 2023
Summary: Pull Request resolved: pytorch#1630 Updates `debug` flag to be an opt-in only. Previously this was filtering out all BoTorchWarnings, which significantly limited usage of these warnings. Differential Revision: D42017622 fbshipit-source-id: d04f12ee4743ffad5ef568d6831c16c3549f6112
saitcakmak
force-pushed
the
export-D42017622
branch
from
413dfa0 to
713feeb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D42017622 |
Codecov Report
@@ Coverage Diff @@
## main #1630 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 154 154
Lines 13783 13776 -7
=========================================
- Hits 13783 13776 -7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Jan 14, 2023
Summary: Pull Request resolved: pytorch#1630 Updates `debug` flag to be an opt-in only. Previously this was filtering out all BoTorchWarnings, which significantly limited usage of these warnings. Differential Revision: D42017622 fbshipit-source-id: a6e5a673faa64d96a090ba70ac4830ef92e9a797
saitcakmak
force-pushed
the
export-D42017622
branch
from
713feeb to
014a362
Compare
|
This pull request was exported from Phabricator. Differential Revision: D42017622 |
Summary: Pull Request resolved: pytorch#1630 Updates `debug` flag to be an opt-in only. Previously this was filtering out all BoTorchWarnings, which significantly limited usage of these warnings. Reviewed By: esantorella Differential Revision: D42017622 fbshipit-source-id: c03115ea404d166de36be53af0aa07a6ebfd7ceb
|
This pull request was exported from Phabricator. Differential Revision: D42017622 |
saitcakmak
force-pushed
the
export-D42017622
branch
from
014a362 to
4f12f5e
Compare
|
This pull request has been merged in 85bbf98. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Updates
debugflag to be an opt-in only. Previously this was filtering out all BoTorchWarnings, which significantly limited usage of these warnings.Differential Revision: D42017622