Fix TransformedPosterior missing batch shape error in _update_base_samples #1625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D42421494 |
|
This pull request was exported from Phabricator. Differential Revision: D42421494 |
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Jan 9, 2023
…mples (pytorch#1625) Summary: Pull Request resolved: pytorch#1625 See pytorch#1623. This is the only use case for `posterior.batch_shape`, so fixing it locally makes sense to me. Differential Revision: D42421494 fbshipit-source-id: 6de08cf0aee948a29f8e128cbded850e2d507608
saitcakmak
force-pushed
the
export-D42421494
branch
from
128b5be to
70f0d8f
Compare
Codecov Report
@@ Coverage Diff @@
## main #1625 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 154 154
Lines 13776 13778 +2
=========================================
+ Hits 13776 13778 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Balandat
approved these changes
Jan 11, 2023
| IIDNormalSampler(sample_shape=torch.Size([2])), | ||
| IIDNormalSampler(sample_shape=torch.Size([2])), | ||
| ) | ||
| # This calls _set_sampler which would previously fail. |
There was a problem hiding this comment.
previously w.r.t to what? This PR?
There was a problem hiding this comment.
Maybe let's update the comment with what the test does specifically rather than saying "previously"? The context will get lost.
…mples (pytorch#1625) Summary: Pull Request resolved: pytorch#1625 See pytorch#1623. This is the only use case for `posterior.batch_shape`, so fixing it locally makes sense to me. Reviewed By: Balandat Differential Revision: D42421494 fbshipit-source-id: 2f6afc41c573419e9aa979f34036b7e30a6802d4
|
This pull request was exported from Phabricator. Differential Revision: D42421494 |
saitcakmak
force-pushed
the
export-D42421494
branch
from
70f0d8f to
83e07d6
Compare
|
This pull request has been merged in 3596b12. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: See #1623. This is the only use case for
posterior.batch_shape, so fixing it locally makes sense to me.Differential Revision: D42421494