Add sample_shape property to ListSampler #1624
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D42421646 |
Summary: Pull Request resolved: pytorch#1624 In some cases, we access sampler.sample_shape, which errors out with ListSampler. This adds a property that returns the sample shape of the underlying samplers. See pytorch#1623 (comment) Differential Revision: D42421646 fbshipit-source-id: ce6053edab6ed9450d7c06f57defff556ae2a63f
saitcakmak
force-pushed
the
export-D42421646
branch
from
8c1299c to
19e6f17
Compare
|
This pull request was exported from Phabricator. Differential Revision: D42421646 |
|
This pull request has been merged in a79071d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In some cases, we access sampler.sample_shape, which errors out with ListSampler. This adds a property that returns the sample shape of the underlying samplers.
See #1623 (comment)
Differential Revision: D42421646