fix chebyshev scalariztaion #1616
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D42373368 |
Balandat
reviewed
Jan 6, 2023
Comment on lines
35
to
38
| Outcomes are multiplied by -1, then normalized to [0,1] for maximization (or [-1,0] for minimization) | ||
| and then an augmented Chebyshev scalarization is applied. | ||
|
|
||
| Since typically the augmented chebyshev scalarization is minimized, we multiply the resulting quantity by -1. |
There was a problem hiding this comment.
Suggested change
| Outcomes are multiplied by -1, then normalized to [0,1] for maximization (or [-1,0] for minimization) | |
| and then an augmented Chebyshev scalarization is applied. | |
| Since typically the augmented chebyshev scalarization is minimized, we multiply the resulting quantity by -1. | |
| Outcomes are multiplied by -1 (since botorch by default assumes maximization | |
| of the underlying outcomes), then normalized to [0,1] for maximization (or [-1,0] | |
| for minimization) and then an augmented Chebyshev scalarization is applied. | |
| Since typically the augmented Chebyshev scalarization is minimized, we | |
| multiply the resulting quantity by -1. |
| @@ -61,6 +63,7 @@ def get_chebyshev_scalarization( | |||
| >>> weights = torch.tensor([0.75, -0.25]) | |||
| >>> transform = get_aug_chebyshev_scalarization(weights, Y) | |||
| """ | |||
| Y = -Y | |||
There was a problem hiding this comment.
Add a comment here? As well as below in the obj definition for clarity?
|
This pull request was exported from Phabricator. Differential Revision: D42373368 |
sdaulton
force-pushed
the
export-D42373368
branch
from
90997db to
ee4eb71
Compare
sdaulton
added a commit
to sdaulton/botorch
that referenced
this pull request
Jan 15, 2023
Summary: Pull Request resolved: pytorch#1616 See pytorch#1614 Differential Revision: D42373368 fbshipit-source-id: 5b705efadd3c1259e8f7fd73964c882f40ae5150
Codecov Report
@@ Coverage Diff @@
## main #1616 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 169 169
Lines 14518 14523 +5
=========================================
+ Hits 14518 14523 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sdaulton
added a commit
to sdaulton/botorch
that referenced
this pull request
Jan 15, 2023
Summary: Pull Request resolved: pytorch#1616 See pytorch#1614 Differential Revision: D42373368 fbshipit-source-id: 828dee51734cc54bf3f01c1876af05f9ae8b7201
sdaulton
force-pushed
the
export-D42373368
branch
from
ee4eb71 to
6f99023
Compare
|
This pull request was exported from Phabricator. Differential Revision: D42373368 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D42373368 |
sdaulton
added a commit
to sdaulton/botorch
that referenced
this pull request
Feb 8, 2023
Summary: Pull Request resolved: pytorch#1616 See pytorch#1614 Differential Revision: D42373368 fbshipit-source-id: 8a297e8fdfe3e237397a62acca556219ccd5c959
sdaulton
force-pushed
the
export-D42373368
branch
from
6f99023 to
36e70ea
Compare
Summary: Pull Request resolved: pytorch#1616 See pytorch#1614 Reviewed By: Balandat Differential Revision: D42373368 fbshipit-source-id: eace05709a824f16a6dfdac0e13d906cc5f8dfd1
sdaulton
force-pushed
the
export-D42373368
branch
from
36e70ea to
3c5b1fd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D42373368 |
|
This pull request has been merged in 3e18d2a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: See #1614
Differential Revision: D42373368