-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nightly PyPI upload test #1610
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@saitcakmak has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Balandat
approved these changes
Jan 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Summary: This was using the pinned version of GPyTorch & linear operator, leading to failures. Pull Request resolved: #1610 Test Plan: PyPI upload test now passes https://github.com/pytorch/botorch/actions/runs/3842548266/jobs/6543945107 Reviewed By: Balandat Differential Revision: D42353988 Pulled By: saitcakmak fbshipit-source-id: c80f6ee228ea870ed8350e2ae753e41053c883a6
This pull request was exported from Phabricator. Differential Revision: D42353988 |
35a54b7
to
e950c9f
Compare
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Jan 5, 2023
Summary: This was using the pinned version of GPyTorch & linear operator, leading to failures. Pull Request resolved: pytorch#1610 Test Plan: PyPI upload test now passes https://github.com/pytorch/botorch/actions/runs/3842548266/jobs/6543945107 Differential Revision: https://internalfb.com/D42353988 Pulled By: saitcakmak fbshipit-source-id: 11fadef68bdc44695b12f8b674f34f9ca4f977ac
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Jan 5, 2023
Summary: This was using the pinned version of GPyTorch & linear operator, leading to failures. Pull Request resolved: pytorch#1610 Test Plan: PyPI upload test now passes https://github.com/pytorch/botorch/actions/runs/3842548266/jobs/6543945107 Differential Revision: https://internalfb.com/D42353988 Pulled By: saitcakmak fbshipit-source-id: 9de9fad14b9f8b6ddc51bf4e0f7311632222f270
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Jan 5, 2023
Summary: This was using the pinned version of GPyTorch & linear operator, leading to failures. Pull Request resolved: pytorch#1610 Test Plan: PyPI upload test now passes https://github.com/pytorch/botorch/actions/runs/3842548266/jobs/6543945107 Differential Revision: https://internalfb.com/D42353988 Pulled By: saitcakmak fbshipit-source-id: 7bebbb5ef08f487572f8865c90e119df791ca974
@saitcakmak merged this pull request in 2f2cd7a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was using the pinned version of GPyTorch & linear operator, leading to failures.
Test plan: PyPI upload test now passes
https://github.com/pytorch/botorch/actions/runs/3842548266/jobs/6543945107