Expose timeout option in higher-level optimziation wrappers #1598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D42254406 |
Balandat
added a commit
to Balandat/botorch
that referenced
this pull request
Dec 28, 2022
…1598) Summary: Pull Request resolved: pytorch#1598 Now that we have the ability to time out the optimization in `scipy.optimize.minimize` at a lower-level, we can expose it also in the higher-level optimization wrappers. Differential Revision: D42254406 fbshipit-source-id: 09680b257172280f991460933c6e76090622b320
|
This pull request was exported from Phabricator. Differential Revision: D42254406 |
Balandat
force-pushed
the
export-D42254406
branch
from
14e04b3 to
6bd5ca4
Compare
Balandat
added a commit
to Balandat/botorch
that referenced
this pull request
Dec 28, 2022
…1598) Summary: Pull Request resolved: pytorch#1598 Now that we have the ability to time out the optimization in `scipy.optimize.minimize` at a lower-level, we can expose it also in the higher-level optimization wrappers. Differential Revision: D42254406 fbshipit-source-id: bc2266f17c39f9f1783fecbe736f68d0abc5d65d
Balandat
force-pushed
the
export-D42254406
branch
from
6bd5ca4 to
2e92d26
Compare
|
This pull request was exported from Phabricator. Differential Revision: D42254406 |
Codecov Report
@@ Coverage Diff @@
## main #1598 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 154 154
Lines 13754 13775 +21
=========================================
+ Hits 13754 13775 +21
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Balandat
added a commit
to Balandat/botorch
that referenced
this pull request
Dec 29, 2022
…1598) Summary: Pull Request resolved: pytorch#1598 Now that we have the ability to time out the optimization in `scipy.optimize.minimize` at a lower-level, we can expose it also in the higher-level optimization wrappers. Differential Revision: D42254406 fbshipit-source-id: 7ad81dde78fc6ef2dd1af7de44c63664d5f063b8
Balandat
force-pushed
the
export-D42254406
branch
from
2e92d26 to
e768134
Compare
|
This pull request was exported from Phabricator. Differential Revision: D42254406 |
Balandat
added a commit
to Balandat/botorch
that referenced
this pull request
Dec 29, 2022
…1598) Summary: Pull Request resolved: pytorch#1598 Now that we have the ability to time out the optimization in `scipy.optimize.minimize` at a lower-level, we can expose it also in the higher-level optimization wrappers. Differential Revision: D42254406 fbshipit-source-id: 24521e214e9548dbfea43320a20e56ec32a5b76b
Balandat
force-pushed
the
export-D42254406
branch
from
e768134 to
a900070
Compare
|
This pull request was exported from Phabricator. Differential Revision: D42254406 |
Balandat
added a commit
to Balandat/botorch
that referenced
this pull request
Dec 29, 2022
…1598) Summary: Pull Request resolved: pytorch#1598 Now that we have the ability to time out the optimization in `scipy.optimize.minimize` at a lower-level, we can expose it also in the higher-level optimization wrappers. Differential Revision: D42254406 fbshipit-source-id: ff2d48549917cddb1a737f3be90186667fbc1476
Balandat
force-pushed
the
export-D42254406
branch
from
a900070 to
f142ee1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D42254406 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D42254406 |
Balandat
added a commit
to Balandat/botorch
that referenced
this pull request
Dec 30, 2022
…1598) Summary: Pull Request resolved: pytorch#1598 Now that we have the ability to time out the optimization in `scipy.optimize.minimize` at a lower-level, we can expose it also in the higher-level optimization wrappers. Reviewed By: esantorella Differential Revision: D42254406 fbshipit-source-id: aeaac9cee7fb52ecda1c11df123cd3419476a48c
Balandat
force-pushed
the
export-D42254406
branch
from
f142ee1 to
7519944
Compare
Balandat
added a commit
to Balandat/Ax
that referenced
this pull request
Dec 30, 2022
…#1598) Summary: X-link: pytorch/botorch#1598 Now that we have the ability to time out the optimization in `scipy.optimize.minimize` at a lower-level, we can expose it also in the higher-level optimization wrappers. Reviewed By: esantorella Differential Revision: D42254406 fbshipit-source-id: 544dbc64abae0adf8693b08ffdb060c7ee7a895e
Balandat
added a commit
to Balandat/botorch
that referenced
this pull request
Dec 30, 2022
…1598) Summary: Pull Request resolved: pytorch#1598 Now that we have the ability to time out the optimization in `scipy.optimize.minimize` at a lower-level, we can expose it also in the higher-level optimization wrappers. Reviewed By: esantorella Differential Revision: D42254406 fbshipit-source-id: a930515861a75d4f4f67202e0d52d83eb92e400b
Balandat
force-pushed
the
export-D42254406
branch
from
7519944 to
53df917
Compare
|
This pull request was exported from Phabricator. Differential Revision: D42254406 |
…1353) Summary: X-link: facebook/Ax#1353 Pull Request resolved: pytorch#1598 Now that we have the ability to time out the optimization in `scipy.optimize.minimize` at a lower-level, we can expose it also in the higher-level optimization wrappers. Reviewed By: esantorella Differential Revision: D42254406 fbshipit-source-id: 251c66a1e57f378e952b103300c1597590577bb0
|
This pull request was exported from Phabricator. Differential Revision: D42254406 |
Balandat
force-pushed
the
export-D42254406
branch
from
53df917 to
4e79434
Compare
Balandat
added a commit
to Balandat/Ax
that referenced
this pull request
Dec 30, 2022
…#1353) Summary: Pull Request resolved: facebook#1353 X-link: pytorch/botorch#1598 Now that we have the ability to time out the optimization in `scipy.optimize.minimize` at a lower-level, we can expose it also in the higher-level optimization wrappers. Reviewed By: esantorella Differential Revision: D42254406 fbshipit-source-id: 75dc6e29796a8d94dcf639ca3b30220a23121341
|
This pull request has been merged in feed9f7. |
facebook-github-bot
pushed a commit
to facebook/Ax
that referenced
this pull request
Dec 30, 2022
Summary: Pull Request resolved: #1353 X-link: pytorch/botorch#1598 Now that we have the ability to time out the optimization in `scipy.optimize.minimize` at a lower-level, we can expose it also in the higher-level optimization wrappers. Reviewed By: esantorella Differential Revision: D42254406 fbshipit-source-id: 740d69a965c9eb373bb22e9c8a7213a13abb9dcc
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Apr 26, 2023
…pytorch#1598) Summary: X-link: facebook/Ax#1598 Pull Request resolved: pytorch#1808 `optimize_acqf` calls `_optimize_acqf_sequential_q` when `sequential=True` and `q > 1`. We had been doing input validation for `_optimize_acqf_sequential` even when it was not called, in the `q=1` case. This unnecessary check became a problem when `sequential=True` became a default for MBM in facebook/Ax#1585 , breaking Ax benchmarks. This PR moves checks for sequential optimization to `_optimize_acqf_sequential_q`, so they will only happen if `_optimize_acqf_sequential_q` is called. Reviewed By: saitcakmak Differential Revision: D45324522 fbshipit-source-id: e5ea7e348eb0ae479e0345ec5254ba5a71642b2a
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Apr 26, 2023
…pytorch#1598) Summary: X-link: facebook/Ax#1598 Pull Request resolved: pytorch#1808 `optimize_acqf` calls `_optimize_acqf_sequential_q` when `sequential=True` and `q > 1`. We had been doing input validation for `_optimize_acqf_sequential` even when it was not called, in the `q=1` case. This unnecessary check became a problem when `sequential=True` became a default for MBM in facebook/Ax#1585 , breaking Ax benchmarks. This PR moves checks for sequential optimization to `_optimize_acqf_sequential_q`, so they will only happen if `_optimize_acqf_sequential_q` is called. Reviewed By: saitcakmak Differential Revision: D45324522 fbshipit-source-id: e9114843acd122c905bd72dde037ba918348549e
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 27, 2023
…#1598) Summary: X-link: facebook/Ax#1598 Pull Request resolved: #1808 `optimize_acqf` calls `_optimize_acqf_sequential_q` when `sequential=True` and `q > 1`. We had been doing input validation for `_optimize_acqf_sequential` even when it was not called, in the `q=1` case. This unnecessary check became a problem when `sequential=True` became a default for MBM in facebook/Ax#1585 , breaking Ax benchmarks. This PR moves checks for sequential optimization to `_optimize_acqf_sequential_q`, so they will only happen if `_optimize_acqf_sequential_q` is called. Reviewed By: saitcakmak Differential Revision: D45324522 fbshipit-source-id: 1757abddcc1e3480c687800605b972c7ae603f8b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Now that we have the ability to time out the optimization in
scipy.optimize.minimizeat a lower-level, we can expose it also in the higher-level optimization wrappers.Differential Revision: D42254406