Introduce ModelDict and MultiModelAcquisitionFunction #1584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Introduces a lightweight `ModelDict` container, which is simply a `ModuleDict[str, Model]`, and an abstract `MultiModelAcquisitionFunction` class that accepts a `ModelDict` rather than a `Model`. The goal here is to help shape the MBM Surrogate refactor by having a concrete example of how the multiple surrogates would be consumed in BoTorch. Reviewed By: lena-kashtelyan Differential Revision: D41564744 fbshipit-source-id: 1ff672a3c713e7213a87536588852973360dee99
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D41564744 |
Codecov Report
@@ Coverage Diff @@
## main #1584 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 153 153
Lines 13641 13651 +10
=========================================
+ Hits 13641 13651 +10
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
This pull request has been merged in ab28cc4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Introduces a lightweight
ModelDictcontainer, which is simply aModuleDict[str, Model], and an abstractMultiModelAcquisitionFunctionclass that accepts aModelDictrather than aModel.The goal here is to help shape the MBM Surrogate refactor by having a concrete example of how the multiple surrogates would be consumed in BoTorch.
Reviewed By: lena-kashtelyan
Differential Revision: D41564744