Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make scipy minimize failure messages more verbose #1579

Closed
wants to merge 1 commit into from

Conversation

saitcakmak
Copy link
Contributor

Summary: I find warnings with "failed with status 2" uninformative. Having the message there should help interpret them better.

Differential Revision: D42156805

@facebook-github-bot facebook-github-bot added CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported labels Dec 19, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D42156805

Summary:
Pull Request resolved: pytorch#1579

I find warnings with "failed with status 2" uninformative. Having the message there should help interpret them better.

Reviewed By: esantorella

Differential Revision: D42156805

fbshipit-source-id: d805f971a77975cc0573ca7ae3f662cd6a5b54a5
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D42156805

@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Merging #1579 (16f6648) into main (76062a6) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main     #1579   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          153       153           
  Lines        13597     13602    +5     
=========================================
+ Hits         13597     13602    +5     
Impacted Files Coverage Δ
botorch/generation/gen.py 100.00% <ø> (ø)
botorch/models/transforms/outcome.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 37e5061.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants