Introducing LogNoisyExpectedImprovement
#1577
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D42109272 |
SebastianAment
added a commit
to SebastianAment/botorch
that referenced
this pull request
Dec 19, 2022
Summary: Pull Request resolved: pytorch#1577 Follow up on D41890063 (pytorch@d819b2d), continuing the logarithmification of improvement-based acquisition functions. Notably, the existing test case for `NEI` already exhibits acquisition values that are exactly zero and gradients on the order of machine epsilon. This is solved by `LogNEI`. Reviewed By: Balandat Differential Revision: D42109272 fbshipit-source-id: fef4dda61cd2fcb1d09af15abe83a9812c88f0b2
SebastianAment
force-pushed
the
export-D42109272
branch
from
ea9aeb3 to
25228a8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D42109272 |
Codecov Report
@@ Coverage Diff @@
## main #1577 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 153 153
Lines 13602 13623 +21
=========================================
+ Hits 13602 13623 +21
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
SebastianAment
added a commit
to SebastianAment/botorch
that referenced
this pull request
Dec 20, 2022
Summary: Pull Request resolved: pytorch#1577 Follow up on D41890063 (pytorch@d819b2d), continuing the logarithmification of improvement-based acquisition functions. Notably, the existing test case for `NEI` already exhibits acquisition values that are exactly zero and gradients on the order of machine epsilon. This is solved by `LogNEI`. Reviewed By: Balandat Differential Revision: D42109272 fbshipit-source-id: 147ece187d973d28cc788e68ad2a1a4db690b12e
SebastianAment
force-pushed
the
export-D42109272
branch
from
25228a8 to
86067d3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D42109272 |
Summary: Pull Request resolved: pytorch#1577 Follow up on D41890063 (pytorch@d819b2d), continuing the logarithmification of improvement-based acquisition functions. Notably, the existing test case for `NEI` already exhibits acquisition values that are exactly zero and gradients on the order of machine epsilon. This is solved by `LogNEI`. Reviewed By: Balandat Differential Revision: D42109272 fbshipit-source-id: 3c8370b4581a57becceb915b82a4850386aa61c4
|
This pull request was exported from Phabricator. Differential Revision: D42109272 |
SebastianAment
force-pushed
the
export-D42109272
branch
from
86067d3 to
fd5bfaa
Compare
|
This pull request has been merged in 8f58784. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Follow up on D41890063 (d819b2d), continuing the logarithmification of improvement-based acquisition functions.
Notably, the existing test case for
NEIalready exhibits acquisition values that are exactly zero and gradients on the order of machine epsilon. This is solved byLogNEI.Reviewed By: Balandat
Differential Revision: D42109272