Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some numerical tweaks to fully Bayesian models #1576

Closed
wants to merge 1 commit into from

Conversation

Balandat
Copy link
Contributor

Summary: Streamlines the code, makes some numerical improvments, and gets rid of redundant computations.

Reviewed By: dme65

Differential Revision: D42061081

@facebook-github-bot facebook-github-bot added CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported labels Dec 17, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D42061081

@codecov
Copy link

codecov bot commented Dec 17, 2022

Codecov Report

Merging #1576 (ae0fa57) into main (b885609) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main     #1576   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          154       154           
  Lines        13741     13741           
=========================================
  Hits         13741     13741           
Impacted Files Coverage Δ
botorch/models/fully_bayesian.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Balandat
Copy link
Contributor Author

This is missing an increment to the loop var i, but there seem to be some larger issues with the numerics here even prior to this PR, holding off with this PR until those are resolved.

Summary:
Pull Request resolved: pytorch#1576

Streamlines the code, makes some numerical improvments, and gets rid of redundant computations.

Reviewed By: dme65, saitcakmak

Differential Revision: D42061081

fbshipit-source-id: fdcbd597f86bb822aa8fad26ab3e0bf000a79bc0
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D42061081

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in b46184b.

@Balandat Balandat deleted the export-D42061081 branch December 29, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants