Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix docstring in ModelList #1573

Closed
wants to merge 2 commits into from

Conversation

jduerholt
Copy link
Contributor

Motivation

This PR fixes an error in the docstring of ModelList. There an example is shown in which a non-existent method named predict is called. I assume, the original intention was to call posterior there.

Have you read the Contributing Guidelines on pull requests?

Yes.

Test Plan

Only fix of a doc string, no additional tests needed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Dec 15, 2022
@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Merging #1573 (b2fa9c2) into main (d819b2d) will not change coverage.
The diff coverage is n/a.

❗ Current head b2fa9c2 differs from pull request most recent head 5d3ca14. Consider uploading reports for the commit 5d3ca14 to get more accurate results

@@            Coverage Diff            @@
##              main     #1573   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          153       153           
  Lines        13601     13601           
=========================================
  Hits         13601     13601           
Impacted Files Coverage Δ
botorch/models/model.py 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@Balandat Balandat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@facebook-github-bot
Copy link
Contributor

@Balandat has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@Balandat merged this pull request in 64c6819.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants